Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-17661 Demonstrate use of this.props.hide() in popover componen… #58

Merged
merged 1 commit into from
Aug 29, 2019
Merged

MM-17661 Demonstrate use of this.props.hide() in popover componen… #58

merged 1 commit into from
Aug 29, 2019

Conversation

MatthewDorner
Copy link
Contributor

To demonstrate changes made in mattermost/mattermost-webapp#3411.

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Aug 19, 2019
@hanzei hanzei requested a review from prapti August 19, 2019 12:43
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label Aug 19, 2019
@hanzei hanzei added this to the v0.2 milestone Aug 19, 2019
devinbinnie
devinbinnie approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@devinbinnie devinbinnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lieut-data lieut-data removed the 2: Dev Review Requires review by a core committer label Aug 20, 2019
prapti
prapti approved these changes Aug 22, 2019
View reviewed changes
Copy link

@prapti prapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be tested with mattermost/mattermost-webapp#3411 post-merge. Removing QA Review label.

@prapti prapti removed the 3: QA Review Requires review by a QA tester label Aug 22, 2019
@hanzei hanzei modified the milestones: v0.2, v0.3 Aug 22, 2019
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) and removed Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) labels Aug 22, 2019
@hanzei hanzei changed the title MM-17661 Demonstrate use of this.props.hide() in popover components. MM-17661 Demonstrate use of this.props.hide() in popover componen… Aug 29, 2019
@hanzei hanzei merged commit 98aed14 into mattermost:master Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prapti prapti prapti approved these changes

@lieut-data lieut-data lieut-data approved these changes

@devinbinnie devinbinnie devinbinnie approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MatthewDorner @prapti @lieut-data @devinbinnie @hanzei