Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync with plugin-starter-template #91

Merged
merged 8 commits into from
Apr 27, 2020
Merged

Sync with plugin-starter-template #91

merged 8 commits into from
Apr 27, 2020

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Mar 9, 2020

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 9, 2020
@hanzei hanzei added this to the v0.6.0 milestone Mar 9, 2020
hanzei
hanzei commented Mar 9, 2020
View reviewed changes
plugin.json
@@ -78,7 +78,7 @@
"display_name": "Secret Message",
"type": "custom",
"help_text": "The message posted by the demo plugin when the secret phrase is detected.",
"default": "Yay! The random secret string was posted!\n\nGo to the settings page for this plugin in the system console to generate a new random secret."
"default": "Yay! The random secret string was posted! Go to the settings page for this plugin in the system console to generate a new random secret."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to change this because \n did play nicely with the js world.

@codecov-io
Copy link

codecov-io commented Mar 9, 2020 •
edited
Loading

Codecov Report

Merging #91 into master will decrease coverage by 0.36%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   17.47%   17.10%   -0.37%     
==========================================
  Files          13       14       +1     
  Lines        1179     1175       -4     
==========================================
- Hits          206      201       -5     
  Misses        934      934              
- Partials       39       40       +1
Impacted Files Coverage Δ
server/activate_hooks.go 75.86% <ø> (-3.83%) ⬇️
server/manifest.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e731d5...641cfc9. Read the comment docs.

@hanzei hanzei requested a review from marianunez March 11, 2020 06:20
jfrerich
jfrerich suggested changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@jfrerich jfrerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume most of this code is a straight copy from starter-template but found one possible weird merge issue.

build/manifest/main.go Show resolved Hide resolved
@hanzei hanzei added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Mar 19, 2020
@hanzei
Copy link
Contributor Author

hanzei commented Mar 19, 2020

Let's wait for mattermost/mattermost-plugin-starter-template#89

@hanzei hanzei requested a review from jfrerich March 19, 2020 11:32
@hanzei hanzei removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Mar 20, 2020
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Mar 21, 2020
@hanzei
Copy link
Contributor Author

hanzei commented Mar 21, 2020

@DHaussermann Would you please give this PR a smoke test?

@hanzei hanzei removed the request for review from DHaussermann April 2, 2020 10:35
@hanzei hanzei added Work In Progress Not yet ready for review and removed 3: QA Review Requires review by a QA tester labels Apr 2, 2020
@hanzei
Copy link
Contributor Author

hanzei commented Apr 2, 2020

Let's wait and cut v0.6.0 first.

@hanzei hanzei modified the milestones: v0.6.0, v0.7.0 Apr 3, 2020
@hanzei hanzei requested a review from DHaussermann April 4, 2020 10:38
@hanzei hanzei added 3: QA Review Requires review by a QA tester and removed Work In Progress Not yet ready for review labels Apr 4, 2020
DHaussermann
DHaussermann approved these changes Apr 25, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment •
edited by hanzei
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • No build or deployment issues
  • Tested all UI events trigger
  • Tested webhook events
  • Other brief regression testing

No issues found.
LGTM!
Sorry for the long delay on this PR.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA and removed 3: QA Review Requires review by a QA tester labels Apr 25, 2020
@hanzei hanzei merged commit c49f951 into master Apr 27, 2020
@hanzei hanzei deleted the sync branch April 27, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marianunez marianunez marianunez approved these changes

@jfrerich jfrerich jfrerich approved these changes

@DHaussermann DHaussermann DHaussermann approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request QA Review Done PR has been approved by QA
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hanzei @codecov-io @marianunez @jfrerich @DHaussermann