Bots #25
Merged
Bots #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
added
1: PM Review
|
The quality of |
jasonblais
approved these changes
Jun 3, 2019
There was a problem hiding this comment.
The changes outlined in the PR description look good. Thanks @hanzei!
Tagging @asaadmahmood for this question |
|
@hanzei Here's one with a larger resolution. |
crspeller
approved these changes
Jun 5, 2019
levb
approved these changes
Jun 6, 2019
| @@ -31,15 +32,20 @@ func TestPlugin(t *testing.T) { | |||
|
|
|||
| str, _ := json.Marshal(user) | |||
|
|
|||
| w.Write([]byte(str)) | |||
| if _, err := w.Write(str); err != nil { | |||
There was a problem hiding this comment.
nit: save the if, require will panic if err anyway
There was a problem hiding this comment.
How do you know this?
levb
added
4: Reviews Complete
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
serverThe best way to review the code is my reviewing the individual commits.
If the refactoring changes are appreciated, I can also apply them to
server/zoom.Fixes #21