Added telemetry, test and bug fix for true up notifications

[Afsoon]

Summary

This PR includes:

• Add Telemetry when an admin clicks on True Up Notifications and their respective test to ensure the event is correct.
• Bug fix where the invite modal now renders conditionally the CTA based on license data. I found this bug during the development of the telemetry ticket.

Ticket Link

Bug: https://mattermost.atlassian.net/browse/MM-50380
Telemetry: https://mattermost.atlassian.net/browse/MM-50343

Release Note

Bug fix where the true up notification in invite modal now render the CTA correctly

[neallred]

LGTM, thanks @Afsoon ! Just a few typos, some verbiage to sync up, and a possible simplification on the overage hook.

[neallred]

Typo nit: Change the various usages of expendable to expandable

[neallred]

Nit: Since we are setting the inner link text dynamically, I tihnk we should change the defaultMessage and i18n/en.json string to say ... check. <a></a>

[neallred]

Nit: since the value of isExpandable depends on the subscription stats call being made and defaults to false, and since the default state of the isExpandable value is already false, I think we can simplify cta to be a useMemo without any useState or useEffect, like this:

const cta = useMemo(() => (
  isExpandable ? formatMessage({
                id: 'licensingPage.overageUsersBanner.ctaExpandSeats',
                defaultMessage: 'Purchase additional seats',
            })
            : formatMessage({
                id: 'licensingPage.overageUsersBanner.cta',
                defaultMessage: 'Contact Sales',
            })
), [isExpandable])

We can use whatever formatting and forms of return for the useMemo, just picked the ternary because it was easy to type in the Github review comment box.

[mattermost-build]

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

[yasserfaraazkhan]

/update-branch

[yasserfaraazkhan]

/e2e-test

[mattermost-build]

Successfully triggered E2E testing!
GitLab pipeline | Test dashboard

[yasserfaraazkhan]

Hi @neallred ,
I tried running the e2e tests locally, for me these were failing and the Stage or group is not mentioned, I think it will not run in ci too. Please let me know if any flag is needed for these to run.

[neallred]

Thanks for the callout! I'll take a look.

[github-actions]

Test Results

       1 files     814 suites   14m 22s ⏱️
6 876 tests 6 875 ✔️ 1 💤 0 ❌
7 004 runs  7 003 ✔️ 1 💤 0 ❌

Results for commit 16df072.

♻️ This comment has been updated with latest results.

[yasserfaraazkhan]

Hi @neallred
I've used cypress to check the cta when 5% and 10 % users threshold. Please let me know if there are other impacted flows we might want to run through.

[marianunez]

Hi @neallred
I've used cypress to check the cta when 5% and 10 % users threshold. Please let me know if there are other impacted flows we might want to run through.

@yasserfaraazkhan I believe that this PR was fixing a bug in the invite modal where it also shows a CTA if they are over the amount of licensed seats. From the original PR description:

Bug fix where the invite modal now renders conditionally the CTA based on license data. I found this bug during the development of the telemetry ticket.

[yasserfaraazkhan]

Hi Nathan, Maria the CTA appears for admin. The user count is same in global banner, console and invite cta

[mm-cloud-bot]

Test server destroyed

[mm-cloud-bot]

Test server destroyed

[amyblais]

/cherry-pick cloud

[mattermost-build]

Cherry pick is scheduled.

[justinegeffen]

@neallred, can you confirm whether there are changes to the telemetry actions that should be documented? Thank you!

[neallred]

I don't see any existing telemetry category covering this, so I think changes are needed. I would place it underneath https://docs.mattermost.com/manage/telemetry.html#event-data, under the "Non-personally Identifiable Diagnostic Information, distinguished by end users and System Admins" section, as its own item, maybe something like True Up Diagnostics: requested help from sales with license true up; attempted to download true up packet.