This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Export browserHistory #4778
Merged
Export browserHistory #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levb
added
2: Dev Review
cpoile
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Talked to Christopher Speller about this, and it looks like there's a good reason for this. Adding it as an object is different from how we've exported others before, but I suppose it leaves it open to add other utils if we need to in the future.
Thanks @larkox!
marianunez
approved these changes
Jan 30, 2020
|
@lev thoughts on the |
saturninoabril
approved these changes
Feb 3, 2020
saturninoabril
added
4: Reviews Complete
amyblais
added
Changelog/Not Needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to make links behave as internal links, we must push the url into the browserHistory object. It is not possible to create a new browserHistory object from the plugins, as it must be passed as a prop to Mattermost app.
Therefore, we are exporting this browserHistory so plugins can create internal links.
Ticket Link
None
Related Pull Requests
Screenshots
None