Skip to content
This repository has been archived by the owner on Jul 5, 2024. It is now read-only.

commands/group, commands/ldap: add e2e tests batch 1 #337

Merged
merged 4 commits into from
Apr 6, 2021
Merged

commands/group, commands/ldap: add e2e tests batch 1 #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17d5260
commands/group, commands/ldap: add e2e tests batch 1
isacikgoz Mar 15, 2021
40c79df
reflect revivew comments
isacikgoz Mar 25, 2021
31a072d
commands/group: add e2e tests batch 2 (#338)
isacikgoz Mar 29, 2021
7c48f0b
add test codes
isacikgoz Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ ifneq ($(wildcard ${ENTERPRISE_DIR}/.*),)
IGNORE:=$(shell echo Enterprise build selected, preparing)
IGNORE:=$(shell rm -rf $(VENDOR_MM_SERVER_DIR)/enterprise)
IGNORE:=$(shell cp -R $(ENTERPRISE_DIR) $(VENDOR_MM_SERVER_DIR))
IGNORE:=$(shell git -C $(VENDOR_MM_SERVER_DIR)/enterprise checkout $(ENTERPRISE_HASH))
IGNORE:=$(shell git -C $(VENDOR_MM_SERVER_DIR)/enterprise checkout $(ENTERPRISE_HASH) --quiet)
IGNORE:=$(shell rm -f $(VENDOR_MM_SERVER_DIR)/imports/imports.go)
IGNORE:=$(shell cp $(VENDOR_MM_SERVER_DIR)/enterprise/imports/imports.go $(VENDOR_MM_SERVER_DIR)/imports/)
endif
Expand Down
350 changes: 349 additions & 1 deletion commands/group_e2e_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (s *MmctlE2ETestSuite) TestChannelGroupDisableCmd() {
s.Run("Should not allow regular user to disable group for channel", func() {
printer.Clean()

err := channelGroupEnableCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
err := channelGroupDisableCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
Expand All @@ -159,3 +159,351 @@ func (s *MmctlE2ETestSuite) TestChannelGroupDisableCmd() {
s.Require().False(ch.IsGroupConstrained())
})
}

func (s *MmctlE2ETestSuite) TestListLdapGroupsCmd() {
s.SetupEnterpriseTestHelper().InitBasic()
configForLdap(s.th)

s.Run("MM-T3977 Should not allow regular user to list LDAP groups", func() {
printer.Clean()

err := listLdapGroupsCmdF(s.th.Client, &cobra.Command{}, nil)
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForSystemAdminAndLocal("MM-T3976 Should list LDAP groups", func(c client.Client) {
printer.Clean()

// we rely on the test data generated for the openldap server
// i.e. "test-data.ldif" script
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this explicit!

err := listLdapGroupsCmdF(c, &cobra.Command{}, nil)
s.Require().NoError(err)
s.Require().NotEmpty(printer.GetLines())
s.Require().Len(printer.GetErrorLines(), 0)
})
}

func (s *MmctlE2ETestSuite) TestChannelGroupStatusCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

channelName := api4.GenerateTestChannelName()
channel, appErr := s.th.App.CreateChannel(&model.Channel{
TeamId: s.th.BasicTeam.Id,
Name: channelName,
DisplayName: "dn_" + channelName,
Type: model.CHANNEL_OPEN,
GroupConstrained: model.NewBool(true),
}, false)
s.Require().Nil(appErr)
defer func() {
err := s.th.App.DeleteChannel(channel, "")
s.Require().Nil(err)
}()

channelName2 := api4.GenerateTestChannelName()
channel2, appErr := s.th.App.CreateChannel(&model.Channel{
TeamId: s.th.BasicTeam.Id,
Name: channelName2,
DisplayName: "dn_" + channelName2,
Type: model.CHANNEL_OPEN,
}, false)
s.Require().Nil(appErr)
defer func() {
err := s.th.App.DeleteChannel(channel2, "")
s.Require().Nil(err)
}()

s.RunForAllClients("MM-T3974 Should allow to get status of a group constrained channel", func(c client.Client) {
printer.Clean()

err := channelGroupStatusCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
s.Require().NoError(err)

s.Require().Len(printer.GetLines(), 1)
s.Require().Equal(printer.GetLines()[0], "Enabled")
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForAllClients("MM-T3975 Should allow to get status of a regular channel", func(c client.Client) {
printer.Clean()

err := channelGroupStatusCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName2})
s.Require().NoError(err)

s.Require().Len(printer.GetLines(), 1)
s.Require().Equal(printer.GetLines()[0], "Disabled")
s.Require().Len(printer.GetErrorLines(), 0)
})
}

func (s *MmctlE2ETestSuite) TestChannelGroupListCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

channelName := api4.GenerateTestChannelName()
channel, appErr := s.th.App.CreateChannel(&model.Channel{
TeamId: s.th.BasicTeam.Id,
Name: channelName,
DisplayName: "dn_" + channelName,
Type: model.CHANNEL_OPEN,
}, false)
s.Require().Nil(appErr)
defer func() {
err := s.th.App.DeleteChannel(channel, "")
s.Require().Nil(err)
}()

id := model.NewId()
group, appErr := s.th.App.CreateGroup(&model.Group{
DisplayName: "dn_" + id,
Name: model.NewString("name" + id),
Source: model.GroupSourceLdap,
Description: "description_" + id,
RemoteId: model.NewId(),
})
s.Require().Nil(appErr)
defer func() {
_, err := s.th.App.DeleteGroup(group.Id)
s.Require().Nil(err)
}()

_, appErr = s.th.App.UpsertGroupSyncable(&model.GroupSyncable{
GroupId: group.Id,
SyncableId: channel.Id,
Type: model.GroupSyncableTypeChannel,
})
s.Require().Nil(appErr)
defer func() {
_, err := s.th.App.DeleteGroupSyncable(group.Id, channel.Id, model.GroupSyncableTypeChannel)
s.Require().Nil(err)
}()

s.Run("MM-T3970 Should not allow regular user to get list of LDAP groups in a channel", func() {
printer.Clean()

err := channelGroupListCmdF(s.th.Client, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForSystemAdminAndLocal("MM-T3969 Should allow to get list of LDAP groups in a channel", func(c client.Client) {
printer.Clean()

err := channelGroupListCmdF(c, &cobra.Command{}, []string{s.th.BasicTeam.Name + ":" + channelName})
s.Require().NoError(err)

s.Require().Len(printer.GetLines(), 1)
gs, ok := printer.GetLines()[0].(*model.GroupWithSchemeAdmin)
s.Require().True(ok)
s.Require().Equal(gs.Group, *group)
s.Require().Len(printer.GetErrorLines(), 0)
})
}

func (s *MmctlE2ETestSuite) TestTeamGroupDisableCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

team, _, cleanUpFn := createTestGroupTeam(s)
defer cleanUpFn()

team.GroupConstrained = model.NewBool(true)
_, err := s.th.App.UpdateTeam(team)
s.Require().Nil(err)

s.Run("MM-T3919 Should not allow regular user to disable group for team", func() {
printer.Clean()

err := teamGroupDisableCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForSystemAdminAndLocal("MM-T3920 Should disable group sync for the team", func(c client.Client) {
printer.Clean()

err := teamGroupDisableCmdF(c, &cobra.Command{}, []string{team.Name})
s.Require().NoError(err)

team.GroupConstrained = model.NewBool(true)
defer func() {
_, err := s.th.App.UpdateTeam(team)
s.Require().Nil(err)
}()

s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)

tm, appErr := s.th.App.GetTeam(team.Id)
s.Require().Nil(appErr)
s.Require().False(tm.IsGroupConstrained())
})
}

func (s *MmctlE2ETestSuite) TestTeamGroupEnableCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

team, _, cleanUpFn := createTestGroupTeam(s)
defer cleanUpFn()

s.Run("MM-T3917 Should not allow regular user to enable group for team", func() {
printer.Clean()

err := teamGroupEnableCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForSystemAdminAndLocal("MM-T3918 Should enable group sync for the team", func(c client.Client) {
printer.Clean()

err := teamGroupEnableCmdF(c, &cobra.Command{}, []string{team.Name})
s.Require().NoError(err)

team.GroupConstrained = model.NewBool(false)
defer func() {
_, err := s.th.App.UpdateTeam(team)
s.Require().Nil(err)
}()

s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)

tm, appErr := s.th.App.GetTeam(team.Id)
s.Require().Nil(appErr)
s.Require().True(tm.IsGroupConstrained())
})
}

func (s *MmctlE2ETestSuite) TestTeamGroupStatusCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

team, _, cleanUpFn := createTestGroupTeam(s)
defer func() {
cleanUpFn()
}()

teamName2 := api4.GenerateTestTeamName()
team2, appErr := s.th.App.CreateTeam(&model.Team{
Name: teamName2,
DisplayName: "dn_" + teamName2,
Type: model.TEAM_INVITE,
})
s.Require().Nil(appErr)
defer func() {
err := s.th.App.PermanentDeleteTeam(team2)
s.Require().Nil(err)
}()

s.Run("MM-T3921 Should not allow regular user to get status of LDAP groups in a team where they are not a member of", func() {
printer.Clean()

err := teamGroupStatusCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
})

_, appErr = s.th.App.AddUserToTeam(team.Id, s.th.BasicUser.Id, s.th.SystemAdminUser.Id)
s.Require().Nil(appErr)

_, appErr = s.th.App.AddUserToTeam(team2.Id, s.th.BasicUser.Id, s.th.SystemAdminUser.Id)
s.Require().Nil(appErr)

s.RunForAllClients("MM-T3922 Should allow to get status of a group constrained team", func(c client.Client) {
printer.Clean()

err := teamGroupStatusCmdF(c, &cobra.Command{}, []string{team.Name})
s.Require().NoError(err)

s.Require().Len(printer.GetLines(), 1)
s.Require().Equal(printer.GetLines()[0], "Enabled")
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForAllClients("MM-T3923 Should allow to get status of a regular team", func(c client.Client) {
printer.Clean()

err := teamGroupStatusCmdF(c, &cobra.Command{}, []string{teamName2})
s.Require().NoError(err)

s.Require().Len(printer.GetLines(), 1)
s.Require().Equal(printer.GetLines()[0], "Disabled")
s.Require().Len(printer.GetErrorLines(), 0)
})
}

func (s *MmctlE2ETestSuite) TestTeamGroupListCmd() {
s.SetupEnterpriseTestHelper().InitBasic()

team, group, cleanUpFn := createTestGroupTeam(s)
defer func() {
cleanUpFn()
}()

s.Run("MM-T3924 Should not allow regular user to get list of LDAP groups in a team", func() {
printer.Clean()

err := teamGroupListCmdF(s.th.Client, &cobra.Command{}, []string{team.Name})
s.Require().Error(err)
s.Require().Len(printer.GetLines(), 0)
s.Require().Len(printer.GetErrorLines(), 0)
})

s.RunForSystemAdminAndLocal("MM-T3925 Should allow to get list of LDAP groups in a team", func(c client.Client) {
printer.Clean()

err := teamGroupListCmdF(c, &cobra.Command{}, []string{team.Name})
s.Require().NoError(err)

s.Require().Len(printer.GetLines(), 1)
gs, ok := printer.GetLines()[0].(*model.GroupWithSchemeAdmin)
s.Require().True(ok)
s.Require().Equal(gs.Group, *group)
s.Require().Len(printer.GetErrorLines(), 0)
})
}

func createTestGroupTeam(s *MmctlE2ETestSuite) (*model.Team, *model.Group, func()) {
teamName := api4.GenerateTestTeamName()
team, appErr := s.th.App.CreateTeam(&model.Team{
Name: teamName,
DisplayName: "dn_" + teamName,
Type: model.TEAM_OPEN,
GroupConstrained: model.NewBool(true),
})
s.Require().Nil(appErr)

id := model.NewId()
group, appErr := s.th.App.CreateGroup(&model.Group{
DisplayName: "dn_" + id,
Name: model.NewString("name" + id),
Source: model.GroupSourceLdap,
Description: "description_" + id,
RemoteId: model.NewId(),
})
s.Require().Nil(appErr)

_, appErr = s.th.App.UpsertGroupSyncable(&model.GroupSyncable{
GroupId: group.Id,
SyncableId: team.Id,
Type: model.GroupSyncableTypeTeam,
})
s.Require().Nil(appErr)

cleanUpFn := func() {
_, err := s.th.App.DeleteGroupSyncable(group.Id, team.Id, model.GroupSyncableTypeTeam)
s.Require().Nil(err)

_, err = s.th.App.DeleteGroup(group.Id)
s.Require().Nil(err)

err = s.th.App.PermanentDeleteTeamId(team.Id)
s.Require().Nil(err)
}

return team, group, cleanUpFn
}
Loading