Skip to content
This repository has been archived by the owner on Jun 28, 2018. It is now read-only.

SQLite Driver #2

Closed
mattes opened this issue Aug 13, 2014 · 11 comments
Closed

SQLite Driver #2

mattes opened this issue Aug 13, 2014 · 11 comments

Comments

@mattes
Copy link
Owner

mattes commented Aug 13, 2014

No description provided.

@mattes
Copy link
Owner Author

mattes commented Aug 13, 2014

@gravis
Copy link
Contributor

gravis commented Oct 14, 2015

While this sounds like a good news, it also prevent from using github.com/mattes/migrate with programs using CGO_ENABLED=0:

/go/src/github.com/mattes/migrate/driver/sqlite3/sqlite3.go:10:2: C source files not allowed when not using cgo or SWIG: sqlite3-binding.c

Maybe drivers should be optional? I really don't need to import / compile mysql, sqlite, mongo, ... etc. where we're using only postgresql...

@mattes
Copy link
Owner Author

mattes commented Oct 14, 2015

Please see #43

@gravis
Copy link
Contributor

gravis commented Oct 14, 2015 via email

@mattes
Copy link
Owner Author

mattes commented Oct 15, 2015

Tests fail... :-)

@gravis
Copy link
Contributor

gravis commented Oct 15, 2015

I'm going to take a look.
Is docker-compose something acceptable for the tests? We're using this for this kind of tests, and this lib is a very good candidate.

@gravis
Copy link
Contributor

gravis commented Oct 15, 2015

Except from 2 panics, and an issue to create the initial keyspace in cassandra, it's almost done (with docker-composer). I'll post the PR today. It will allow collaborators to run all the tests with just make test, without installing anything. This could probably be improved with various image versions (postgres:9.3, postgres:9.3, etc.), but at least we have a good base here.

@mattes
Copy link
Owner Author

mattes commented Oct 15, 2015

I was thinking about using Docker for the build process, too. I would suggest one single Dockerfile with all dependencies (postgres, mysql, ...) installed. I don't think docker-compose is necessary here.

I don't know if travis supports running containers though.

@mattes
Copy link
Owner Author

mattes commented Oct 15, 2015

Oh, just read your second post. Forgot to refresh the page. Ok, cool. Waiting for your PR then.

@gravis
Copy link
Contributor

gravis commented Oct 15, 2015

#54
PTAL while I'm fixing travis

@gravis
Copy link
Contributor

gravis commented Oct 15, 2015

btw, if you want to run the tests, just start a docker, make sure your env is setup (eval "$(docker-machine env default)" or whatever machine), and run make test. This will pull and start the various DBs.

sigmunau referenced this issue in feideconnect/migrate Sep 28, 2016
correct other import paths in CI and tests
@mattes mattes closed this as completed Dec 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants