This repository has been archived by the owner on Jun 28, 2018. It is now read-only.
Don't load in all drivers by default #40 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires activating drivers with a _ style import, e.g. import "_ github.com/mattes/migrate/driver/postgres"
|
It's failing on Go 1.2 as apparently gocql (at least recently) does not support Go 1.2. |
|
Stumbled across this one too. |
|
thats a nice addition, could you guys fix it @lepoetemaudit @mattes ? |
|
I think this has been superseded by some other PRs and plus it's now somewhat behind master, but I'm willing to fix the conflicts and upate it if @mattes wishes |
|
Although this will break existing code, I feel it's worth it to merge this. It has been requested a lot. @lepoetemaudit, do you think you have time to rebase with master? |
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires activating drivers with a _ style import, e.g.
import _ " github.com/mattes/migrate/driver/postgres"I guess it's not fully backwards compatible (users will need to add the import for the driver they wish to use) but it avoids all dependencies being pulled in when they aren't needed.