This repository has been archived by the owner. It is now read-only.

Proposed fix for migration file name clashes #48

Merged
merged 3 commits into from Sep 15, 2015

Conversation

Projects
None yet
2 participants
@johnweldon
Contributor

johnweldon commented Sep 6, 2015

This is a proposed fix for #45

I added a unit test to demonstrate the issue, and a proposed solution. Both the test and the fix could be leveraged for more refactoring if that's of interest.

johnweldon added some commits Sep 6, 2015

Test to demonstrate issue #45
Added a unit test to demonstrate the problem in issue #45

The introduced makeFiles() function could be used to simplify the other
tests too, but I didn't touch more than necessary for this commit.
Proposed fix for #45
This is the bare minimum proposed fix for #45

By using a nested map the way I do in this PR we could also simplify the
logic further down where we look for matching direction.Up or
direction.Down migrations.

mattes added a commit that referenced this pull request Sep 15, 2015

Merge pull request #48 from johnweldon/45-migration-file-id-clash
Proposed fix for migration file name clashes

@mattes mattes merged commit e857fcc into mattes:master Sep 15, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mattes

This comment has been minimized.

Owner

mattes commented Sep 15, 2015

Thanks! 👍

@johnweldon johnweldon deleted the johnweldon:45-migration-file-id-clash branch Sep 15, 2015

@johnweldon

This comment has been minimized.

Contributor

johnweldon commented Sep 15, 2015

Thanks @mattes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.