Skip to content
This repository has been archived by the owner. It is now read-only.

Proposed fix for migration file name clashes #48

Merged
merged 3 commits into from Sep 15, 2015
Merged

Proposed fix for migration file name clashes #48

merged 3 commits into from Sep 15, 2015

Conversation

@johnweldon
Copy link
Contributor

@johnweldon johnweldon commented Sep 6, 2015

This is a proposed fix for #45

I added a unit test to demonstrate the issue, and a proposed solution. Both the test and the fix could be leveraged for more refactoring if that's of interest.

johnweldon added 3 commits Sep 6, 2015
Added a unit test to demonstrate the problem in issue #45

The introduced makeFiles() function could be used to simplify the other
tests too, but I didn't touch more than necessary for this commit.
This is the bare minimum proposed fix for #45

By using a nested map the way I do in this PR we could also simplify the
logic further down where we look for matching direction.Up or
direction.Down migrations.
mattes added a commit that referenced this issue Sep 15, 2015
Proposed fix for migration file name clashes
@mattes mattes merged commit e857fcc into mattes:master Sep 15, 2015
1 check passed
Loading
@mattes
Copy link
Owner

@mattes mattes commented Sep 15, 2015

Thanks! 👍

Loading

@johnweldon johnweldon deleted the 45-migration-file-id-clash branch Sep 15, 2015
@johnweldon
Copy link
Contributor Author

@johnweldon johnweldon commented Sep 15, 2015

Thanks @mattes

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants