Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul config file does not notify handler #15

Open
bryanlarsen opened this issue Nov 24, 2014 · 3 comments
Open

consul config file does not notify handler #15

bryanlarsen opened this issue Nov 24, 2014 · 3 comments

Comments

@bryanlarsen
Copy link

If the consul config file changes, it should notify a handler to restart consul.

@robbiet480
Copy link
Contributor

👍 on this. I guess i'll just manually run the handler. It may be good to add a handler to reload consul instead of restarting it, if it's only for a configuration change

@MrMMorris
Copy link
Contributor

I would definitely try to avoid restarting automatically especially with Consul Servers. Reload makes sense though

@trumant
Copy link

trumant commented Jun 5, 2015

The one problem is that we'd need to be really smart in the handler to determine whether reload or restart is needed given this: https://consul.io/docs/agent/options.html#reloadable-configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants