Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag a new version with the security fix #191

Closed
atuttle opened this issue Sep 14, 2020 · 11 comments
Closed

Tag a new version with the security fix #191

atuttle opened this issue Sep 14, 2020 · 11 comments

Comments

@atuttle
Copy link

atuttle commented Sep 14, 2020

I see that you updated your node-fetch dependency a couple of hours ago to fix a minor security vulnerability. I'm here looking for an updated version because I received the same vulnerability notification from :octocat:... So I'm probably not the only one looking for a new version of isomorphic-fetch that I can slap into my package.json to make the alert go away. :)

@yizhiheng
Copy link

yes, please fix this 🙏

@AndrijBartenev
Copy link

Yes, that would be really great!

@matthew-andrews
Copy link
Owner

Ah yes indeed, this is the plan … have you tested it … are you confident that it works for you all?

@shanytc
Copy link

shanytc commented Sep 16, 2020

Would be great for a new release with node-fetch updated

@cberg-zalando
Copy link

@matthew-andrews As it is still a new version and due to node's dependency mechanism users will not directly update if they don't actively do it via package.json or recreating a lockfile, I would say, just release it.

@a-reuss
Copy link

a-reuss commented Sep 18, 2020

Dear @matthew-andrews, as @cberg-zalando mentioned, nobody has to apply the new version and we (our team) would really appreciate you to release an updated version of isomorphic-fetch as it is the only simple way to keep our live product secure. We really do rely on this.

Thanks and with best regards

@lkuechler
Copy link

@matthew-andrews I just tested it in one of my projects. I cloned the repository and linked it as a resolution in my project.

With the new version everything worked the same as before. This is obviously not an in depth test but maybe already gives some more certainty.

@bertold
Copy link

bertold commented Sep 18, 2020

Could you, please, release the new version. The last released version 2.2.1 is from 5 years ago.

@vzaidman
Copy link

+1

@shanytc
Copy link

shanytc commented Sep 21, 2020

@matthew-andrews when a new tag release?

@matthew-andrews
Copy link
Owner

Thanks for your testing @lkuechler … it matches what I see.

It has been published at v3.0.0 as the underlying dependencies (node-fetch and the fetch browser polyfill) have been pulled from new major versions.

% npm publish
+ isomorphic-fetch@3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants