components being grouped across different designators

[Shackmeister]

From how I see it, the tool should only try to group components if they are the same designator type (R1, R5, R10 etc) besides FP, value etc.

An NTC resistor with same value and FP as a normal resistor, gave me this warning:
"Components R5, TH1 from same group have different LCSC part numbers: C25744, C92371"
Is this a bug or by design?

[matthewlai]

That's actually how KiCad's netlist parsing script groups components:

JLCKicadTools/jlc_kicad_tools/jlc_lib/kicad_netlist_reader.py

Line 651 in 6e19b39

def groupComponents(self, components = None):

JLCKicadTools/jlc_kicad_tools/jlc_lib/kicad_netlist_reader.py

Line 338 in 6e19b39

def __eq__(self, other):

I agree it makes sense to also use refdes. Happy for you to change it if you have a moment for a PR.

[Shackmeister]

hmm currently it seems like by build uses the internal libraries for the Kicad modules.
Would you know how to force it to use the ones in the repo?

[matthewlai]

Are you sure? The library is imported by path:

JLCKicadTools/jlc_kicad_tools/jlc_lib/generate_bom.py

Line 19 in 6e19b39

from jlc_kicad_tools.jlc_lib import kicad_netlist_reader

Though it's possible that if you installed with pip it may be using an installed copy. I would suggest uninstalling from pip, and just git clone the repo instead.

[Shackmeister]

Fixed in #20