Skip to content
This repository has been archived by the owner on May 22, 2019. It is now read-only.

Forward slashes in URIs? #11

Closed
aengelberg opened this issue Dec 4, 2014 · 3 comments
Closed

Forward slashes in URIs? #11

aengelberg opened this issue Dec 4, 2014 · 3 comments

Comments

@aengelberg
Copy link

I notice that your internal URI validator only accepts "a.b.c..." with no acceptance for forward slashes. Since the WAMP specification says that a realm name can be any URI, I naturally assumed that slashes could be included, such as "a.b/c" and I was surprised to find that jawampa didn't support it. While designing the library, how did you arrive at your decision to exclude forward slashes? Did you find any resources that specified more strict requirements for the URIs, and if so can you point me to them?

@Matthias247
Copy link
Owner

Hi,
I copied the regex from the WAMP spec and assumed it to be correct. However it seems the spec was changed somewhere and I copied an old version. It will change it for the most recent one.

@Matthias247
Copy link
Owner

Ah, I looked through it once more: The specification mentions strict and loose URIs. I went for the strict URI checking as it is the recommended rule and I don't see a necessity to have arbitrary identifers in the URI.
However I see that it might cause problems if one library implements strict uris and the remote peer implementes the relaxed version. It's probably a thing that should be reworked in the WAMP specification.

@aengelberg
Copy link
Author

Thanks for the speedy response. I just found the part in the document where it shows the regexes. Since jawampa seems to already correctly implement the strict URIs, I no longer need you to change it; we will change our API design and adapt our realm names.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants