Plan will be deleted after deleting all trashed items

[matthiku]

This happens when you try to delete a plan from the Plan List view and the plan still contains trashed items. You get an error saying that the plan is not empty and you will be directed to the Plan Details page. But the URL now is plans/{id}/delete, and so when the user clicks on the short-cut "Delete all trashed items permanently", the trashed items will be deleted but the plan also!

[matthiku]

Problem was that the deleteAllTrashed() method in the ItemController sends the user back to the previous page. In this case, it was the 'delete Plan' URl, and so this action is repeated and now is successful since all items incl. the trashed items are gone.

Big question is: while this is not intended, can it still be acceptable since it only happens when a user wanted to delete a plan anyway?

[matthiku]

Nothing changed

I'll leave this behaviour as is for now since it seems to be convenient....