New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded symbols and magic numbers #24

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@MuchtarSalimov

MuchtarSalimov commented Oct 15, 2018

As suggest in #19, I attempted to identify appropriate places to remove hard-coding. Please let me know if any adjustments should be made.

@mattiadg

This comment has been minimized.

Owner

mattiadg commented Oct 15, 2018

It seems nice, but there is the enum GameState that declares the victory of one of the two players, the draw or game to be continued. Please, use that instead of new constants.

@mattiadg mattiadg referenced this pull request Oct 15, 2018

Closed

Remove hardcoded symbols #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment