BUG: non-uint-aligned arrays were counted as uint-aligned #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
pushed a commit
that referenced
this pull request
Mar 20, 2019
Add function types directly to prng_t to simplify use Clean distributionsto use new syntex Remove unused type definitions Rename type definitions to me more meaningful xref #1
mattip
pushed a commit
that referenced
this pull request
Mar 20, 2019
Merge latest updates to my fork.
mattip
pushed a commit
that referenced
this pull request
May 20, 2019
Add function types directly to prng_t to simplify use Clean distributionsto use new syntex Remove unused type definitions Rename type definitions to me more meaningful xref #1
mattip
pushed a commit
that referenced
this pull request
Feb 5, 2021
…py#18295) * BUG: don't mutate list of fake libraries while iterating over it * BUG: iterate over copy of list * TST: add build test for build_ext fix (#1) * TST: add build test for build_ext fix * TST: clearer test name * STY: use triple quotes instead of lists of strings * FIX: check for f77 compiler before test is run * DOC: add comment explaining that a list copy is necessary
mattip
pushed a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matti. I think this is the correct fix:
raw_array_is_alignedshould return false if the queried alignment is the dummy value0returned bynpy_uint_alignment.