-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Sync with randomgen changes #2
Conversation
Synchronize with changes in randomgen
Absolutely better than me trying to merge it from bashtage/randomgen. |
It is failing for some strange reason that seems unrelated to these changes: https://travis-ci.org/bashtage/numpy/builds/514226868
|
Strange. Does that reproduce locally? |
No, passes locally. |
It does repro locally, on both Windows and Linux. I was only running tests under random, and so I didn't see it. |
It looks like the precision is being changed somewhere to that it isn't rounding right. This is a formatted string. I also tried rebasing which didn't fix things. |
It should be |
Interesting, it is similar to an issue we have on linux32 wheel builds where something is reducing floating point accuracy. A compiler glitch? Some assemble code somewhere changing registers? |
Incorporate testing of edge cases into main tests Rename test files to describe their purpose
9e87187
to
ce5857d
Compare
It is my fault - I left a np.set_printiontions(precision=20) in a test. |
@@ -6,6 +7,7 @@ from randomgen.common cimport * | |||
from randomgen.distributions cimport random_gauss_zig | |||
from randomgen.xoroshiro128 import Xoroshiro128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from numpy.random.radomgen
@@ -1138,7 +1002,7 @@ cdef class RandomGenerator: | |||
""" | |||
random_integers(low, high=None, size=None) | |||
|
|||
Random integers of type np.int64 between `low` and `high`, inclusive. | |||
Random integers of type np.int between `low` and `high`, inclusive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On 32 bit systems this gives int32
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, also on all bitness Windows. This function is deprecated and IMO should be removed before this transition.
Import import locatiosn to reflect numpy paths
This is final from my end. I think it gets it very close, although I know there are still docs and I'm sure other things. Coverage is pretty good -- should be the same as randomgen: https://codecov.io/gh/bashtage/randomgen It is in the low 90s but coverage flags all |
Thanks. Merging like this is much simpler than hand-importing from randomgen |
commit 9c833bed5879d77e625556260690c349de18b433 Author: Thomas Li <47963215+lithomas1@users.noreply.github.com> Date: Wed Nov 17 16:21:27 2021 -0800 Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Update LICENSE_win32.txt Update LICENSE_win32.txt Add Windows config to GHA update script [wheel build] typo [wheel build] fix typo? [wheel build] fix linux builds? [wheel build] typo [wheel build] add license and pin to windows 2016 skip tests [wheel build] pin to windows 2019 instead [wheel build] try to find out the error on windows [wheel build] maybe fix? [wheel build] maybe fix? [wheel build] fix? [wheel build] cleanup [wheel build] Update LICENSE_win32.txt Update LICENSE_win32.txt Update cibw_test_command.sh commit 4bd12df Author: Thomas Li <47963215+lithomas1@users.noreply.github.com> Date: Mon Nov 15 17:28:47 2021 -0800 # This is a combination of 14 commits. # This is the 1st commit message: Add Windows config to GHA # This is the commit message #2: update script [wheel build] # This is the commit message #3: typo [wheel build] # This is the commit message #4: fix typo? [wheel build] # This is the commit message #5: fix linux builds? [wheel build] # This is the commit message #6: typo [wheel build] # This is the commit message #7: add license and pin to windows 2016 # This is the commit message #8: skip tests [wheel build] # This is the commit message #9: pin to windows 2019 instead [wheel build] # This is the commit message #10: try to find out the error on windows [wheel build] # This is the commit message #11: maybe fix? [wheel build] # This is the commit message #12: maybe fix? [wheel build] # This is the commit message #13: fix? [wheel build] # This is the commit message #14: cleanup [wheel build]
Synchronize with changes in randomgen
This is a very large PR that brings in all of the changes from randomgen.
The most important are:
I'm not sure this is the best way tot get these in. I fyou think it is better to pull from randomgen then please pull these in the best way.