-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin still in use? We've updated the VoIP Call Code for our purposes / Video calls... #17
Comments
Hi, I just briefly glanced through the PR. It seems fine if I were to merge it into the current code base if it can help other people. However, this code is kinda obsolete since I've published it. There are a lot of changes that I've implemented based on this code base. The reason why I couldn't share my current code is it is kinda "close-source" since it is being used in a production app and I'm not allowed to share it. The main goal of this repo is to provide an idea or a solution (a base) on how to overcome the limitation that Apple has imposed on us when using hybrid development. Maybe I should just archive this repo since I'm not maintaining it at all since I've made this. Thanks for the PR. Appreciate as always. |
Could you please describe the changes you made to understand what problems you solved. Without code, but to understand what problems will need to be solved after installing the plugin. Thank you. |
@seoplague The changes I've implemented are mostly bug fixes for Android to suit my current environment. The plugin is fairly stable for iOS though. One of them is toggling the speakers but this only applies to Android since certain versions of Android is broken. For iOS, it is being handled by another plugin. |
...and would like to know if you think it'd be worth adding these changes back to this repo and/or maybe having to make them more "generic" to be able to fulfil both your original purpose (I guess audio only calls?) as well as video calls.
We'll do a WIP PR so you can have a quick look at our changes, you don't have to merge as-is, it's just so you can have a look in case you might be interested in having these changes integrated.
We're also updating
cordova-plugin-push
in order to enable video calls on the android side too.All the best!
The text was updated successfully, but these errors were encountered: