Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(weekView): Allow drag outside calendar view #214

Merged
merged 12 commits into from
May 27, 2017

Conversation

ElieSauveterre
Copy link
Contributor

External events can be drag'n'drop from the calendar view to a drop zone

Elie Sauveterre added 5 commits May 19, 2017 10:23
Allow Y axis drag;
Set dragData;
Remove dragStart event : no need to validate where the event is dragged to;
Remove dragSnapGrid because outside the calendar we should be able to drag where we want;
Remove validateDrag : no need to valide for external dragndrop
Allow events to be dragged from the calendar view to a drop zone
@mattlewis92
Copy link
Owner

Thanks for this! Rather than removing the old functionality can we retain the existing behaviour and have this opt in via an option like [allowDragOutside]="true".

@ElieSauveterre
Copy link
Contributor Author

@mattlewis92 It's done. What do you think ?

@codecov-io
Copy link

codecov-io commented May 26, 2017

Codecov Report

Merging #214 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   96.99%   97.04%   +0.05%     
==========================================
  Files          30       30              
  Lines         565      576      +11     
  Branches       45       49       +4     
==========================================
+ Hits          548      559      +11     
  Partials       17       17
Impacted Files Coverage Δ
src/components/week/calendarWeekView.component.ts 94.73% <100%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8553aa6...41fbdd6. Read the comment docs.

@mattlewis92
Copy link
Owner

@ElieSauveterre I've tweaked the logic so that if a user drags the event outside of the calendar view the event start and end dates are always changed by a fixed number of days rather than using the start and end of the week - what do you think?

@ElieSauveterre
Copy link
Contributor Author

@mattlewis92 That's better. Thanks.

@mattlewis92 mattlewis92 merged commit dcff88a into mattlewis92:master May 27, 2017
@mattlewis92
Copy link
Owner

Released as 0.16.0, thanks for the contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants