-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add support for custom container css class #299
Conversation
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 29 29
Lines 516 516
Branches 49 49
=======================================
Hits 497 497
Partials 19 19
Continue to review full report at Codecov.
|
Hi there, thanks for the PR, would you mind explaining a bit more about your use case for this? I'm just curious as I didn't imagine a situation where you would need to add a class on the container which is only used as a way of controlling drag + drop / resizing which shouldn't require any additional styling. Thanks! |
Hi @mattlewis92 https://www.dropbox.com/s/wnygrddt5vsoesk/Screenshot%202017-08-03%2013.32.09.png?dl=0 There can be max two events at the same time, so they need to share the hour segment. Thanks. |
Ah ok that makes sense, thanks for taking the time to explain (also its super cool to see this lib being used in creative ways like this! 😄 ). I think it might be better if the event |
Indeed! Yeah it makes more sense to add it to the container. Would you like to make that change? Or should I? But then we need a way to migrate from the older versions, any suggestions? |
I've just cut |
Great! Thank you. I appreciate. :) |
This
cal-event-container
was not present in the older versions.Let's add a way to customize it, similar to how we do it for the event itself (with
cssClass
).Thanks!