Skip to content

Commit

Permalink
chromium: Drop passthru.updateScript
Browse files Browse the repository at this point in the history
The update script for Chromium does not behave like other update
scripts, e.g., it updates all channels and ungoogled-chromium (not just
a single package). This causes issues when r-ryantm (the bot that runs
nixpkgs-update) tries to update chromium and ungoogled-chromium (which
it started to do recently):
- NixOS#207185
- NixOS#207482
- NixOS#207596
- NixOS#208048
- NixOS#208287

We could make the update script work as expected by other tooling but
Chromium requires special attention anyway so it might also be for the
best to do it manually for now (at least someone needs to ensure that
the correct labels are set and that security fixes (~ all updates) are
backported).
  • Loading branch information
primeos authored and mattmelling committed Jan 4, 2023
1 parent 1ecd118 commit 9c57d79
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion pkgs/applications/networking/browsers/chromium/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,5 @@ in stdenv.mkDerivation {
inherit (chromium) upstream-info browser;
mkDerivation = chromium.mkChromiumDerivation;
inherit chromeSrc sandboxExecutableName;
updateScript = ./update.py;
};
}

0 comments on commit 9c57d79

Please sign in to comment.