Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chromium: 108.0.5359.124 -> 108.0.5359.124 #207482

Closed
wants to merge 1 commit into from

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for chromium is: "An open source web browser from Google"

meta.homepage for chromium is: "https://www.chromium.org/"

meta.changelog for chromium is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 108.0.5359.124 with grep in /nix/store/f7ac4x35hh4hq0bzqrzarsn7yn2xarg0-chromium-108.0.5359.124
  • found 108.0.5359.124 in filename of file in /nix/store/f7ac4x35hh4hq0bzqrzarsn7yn2xarg0-chromium-108.0.5359.124

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
google-chrome-dev
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/f7ac4x35hh4hq0bzqrzarsn7yn2xarg0-chromium-108.0.5359.124 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A chromium https://github.com/r-ryantm/nixpkgs/archive/fefd192ac70b5f0e5ee49fb903f19f84e59d1ceb.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/f7ac4x35hh4hq0bzqrzarsn7yn2xarg0-chromium-108.0.5359.124
ls -la /nix/store/f7ac4x35hh4hq0bzqrzarsn7yn2xarg0-chromium-108.0.5359.124/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • chromiumDev
1 package built:
  • google-chrome-dev

Maintainer pings

cc @primeos @thefloweringash for testing.

@primeos
Copy link
Member

primeos commented Dec 25, 2022

Need to fix passthru.UpdateScript.

@primeos primeos closed this Dec 25, 2022
@r-ryantm r-ryantm deleted the auto-update/chromium branch December 25, 2022 20:05
primeos added a commit to primeos/nixpkgs that referenced this pull request Jan 1, 2023
The update script for Chromium does not behave like other update
scripts, e.g., it updates all channels and ungoogled-chromium (not just
a single package). This causes issues when r-ryantm (the bot that runs
nixpkgs-update) tries to update chromium and ungoogled-chromium (which
it started to do recently):
- NixOS#207185
- NixOS#207482
- NixOS#207596
- NixOS#208048
- NixOS#208287

We could make the update script work as expected by other tooling but
Chromium requires special attention anyway so it might also be for the
best to do it manually for now (at least someone needs to ensure that
the correct labels are set and that security fixes (~ all updates) are
backported).
@primeos primeos mentioned this pull request Jan 1, 2023
13 tasks
mattmelling pushed a commit to mattmelling/nixpkgs that referenced this pull request Jan 4, 2023
The update script for Chromium does not behave like other update
scripts, e.g., it updates all channels and ungoogled-chromium (not just
a single package). This causes issues when r-ryantm (the bot that runs
nixpkgs-update) tries to update chromium and ungoogled-chromium (which
it started to do recently):
- NixOS#207185
- NixOS#207482
- NixOS#207596
- NixOS#208048
- NixOS#208287

We could make the update script work as expected by other tooling but
Chromium requires special attention anyway so it might also be for the
best to do it manually for now (at least someone needs to ensure that
the correct labels are set and that security fixes (~ all updates) are
backported).
primeos added a commit to primeos/nixpkgs that referenced this pull request Jan 10, 2023
The update script for Chromium does not behave like other update
scripts, e.g., it updates all channels and ungoogled-chromium (not just
a single package). This causes issues when r-ryantm (the bot that runs
nixpkgs-update) tries to update chromium and ungoogled-chromium (which
it started to do recently):
- NixOS#207185
- NixOS#207482
- NixOS#207596
- NixOS#208048
- NixOS#208287

We could make the update script work as expected by other tooling but
Chromium requires special attention anyway so it might also be for the
best to do it manually for now (at least someone needs to ensure that
the correct labels are set and that security fixes (~ all updates) are
backported).

(cherry picked from commit c9ca13c)
miker2049 pushed a commit to miker2049/nixpkgs that referenced this pull request Jan 15, 2023
The update script for Chromium does not behave like other update
scripts, e.g., it updates all channels and ungoogled-chromium (not just
a single package). This causes issues when r-ryantm (the bot that runs
nixpkgs-update) tries to update chromium and ungoogled-chromium (which
it started to do recently):
- NixOS#207185
- NixOS#207482
- NixOS#207596
- NixOS#208048
- NixOS#208287

We could make the update script work as expected by other tooling but
Chromium requires special attention anyway so it might also be for the
best to do it manually for now (at least someone needs to ensure that
the correct labels are set and that security fixes (~ all updates) are
backported).

(cherry picked from commit c9ca13c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants