-
-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chromium: 108.0.5359.124 -> 108.0.5359.124 #207185
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll probably have to add Chromium to the |
primeos
added a commit
to primeos/nixpkgs
that referenced
this pull request
Jan 1, 2023
The update script for Chromium does not behave like other update scripts, e.g., it updates all channels and ungoogled-chromium (not just a single package). This causes issues when r-ryantm (the bot that runs nixpkgs-update) tries to update chromium and ungoogled-chromium (which it started to do recently): - NixOS#207185 - NixOS#207482 - NixOS#207596 - NixOS#208048 - NixOS#208287 We could make the update script work as expected by other tooling but Chromium requires special attention anyway so it might also be for the best to do it manually for now (at least someone needs to ensure that the correct labels are set and that security fixes (~ all updates) are backported).
13 tasks
mattmelling
pushed a commit
to mattmelling/nixpkgs
that referenced
this pull request
Jan 4, 2023
The update script for Chromium does not behave like other update scripts, e.g., it updates all channels and ungoogled-chromium (not just a single package). This causes issues when r-ryantm (the bot that runs nixpkgs-update) tries to update chromium and ungoogled-chromium (which it started to do recently): - NixOS#207185 - NixOS#207482 - NixOS#207596 - NixOS#208048 - NixOS#208287 We could make the update script work as expected by other tooling but Chromium requires special attention anyway so it might also be for the best to do it manually for now (at least someone needs to ensure that the correct labels are set and that security fixes (~ all updates) are backported).
primeos
added a commit
to primeos/nixpkgs
that referenced
this pull request
Jan 10, 2023
The update script for Chromium does not behave like other update scripts, e.g., it updates all channels and ungoogled-chromium (not just a single package). This causes issues when r-ryantm (the bot that runs nixpkgs-update) tries to update chromium and ungoogled-chromium (which it started to do recently): - NixOS#207185 - NixOS#207482 - NixOS#207596 - NixOS#208048 - NixOS#208287 We could make the update script work as expected by other tooling but Chromium requires special attention anyway so it might also be for the best to do it manually for now (at least someone needs to ensure that the correct labels are set and that security fixes (~ all updates) are backported). (cherry picked from commit c9ca13c)
miker2049
pushed a commit
to miker2049/nixpkgs
that referenced
this pull request
Jan 15, 2023
The update script for Chromium does not behave like other update scripts, e.g., it updates all channels and ungoogled-chromium (not just a single package). This causes issues when r-ryantm (the bot that runs nixpkgs-update) tries to update chromium and ungoogled-chromium (which it started to do recently): - NixOS#207185 - NixOS#207482 - NixOS#207596 - NixOS#208048 - NixOS#208287 We could make the update script work as expected by other tooling but Chromium requires special attention anyway so it might also be for the best to do it manually for now (at least someone needs to ensure that the correct labels are set and that security fixes (~ all updates) are backported). (cherry picked from commit c9ca13c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for chromium is: "An open source web browser from Google"
meta.homepage for chromium is: "https://www.chromium.org/"
meta.changelog for chromium is: ""
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
passthru.tests
, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-users
list or you can usesudo
since root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-review
run on x86_64-linux 11 package failed to build:
1 package built:
Maintainer pings
cc @primeos @thefloweringash for testing.