Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make partial_plot use NSE #1

Open
mattmills49 opened this issue Jul 13, 2016 · 0 comments
Open

Make partial_plot use NSE #1

mattmills49 opened this issue Jul 13, 2016 · 0 comments
Assignees

Comments

@mattmills49
Copy link
Owner

I'd like the partial_plot function to use non-standard evaluation so the function call doesn't have to use character values. Both for the code to be cleaner and because I want to learn how NSE works.

For example here is how the function currently works:

test_model <- mgcv::gam(mpg ~ s(hp), data = mtcars)
partial_plot(test_model, "hp")

But I'd like it to drop the quotes

partial_plot(test_model, hp)
@mattmills49 mattmills49 self-assigned this Jul 13, 2016
@mattmills49 mattmills49 changed the title Make partial_plots use NSE Make partial_plot use NSE Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant