Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support skipping textDocument/formatting with requireMarker too #214

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Support skipping textDocument/formatting with requireMarker too #214

merged 1 commit into from
Apr 20, 2022

Conversation

fsouza
Copy link
Contributor

@fsouza fsouza commented Apr 19, 2022

Closes #213.

@fsouza
Copy link
Contributor Author

fsouza commented Apr 19, 2022

Fixed CI in #215. I can also send a PR (or update this one) documenting requireMarker.

@mattn
Copy link
Owner

mattn commented Apr 20, 2022

LGTM. I'll test this in later. Thanks.

@mattn mattn merged commit 3b011bc into mattn:master Apr 20, 2022
@mattn
Copy link
Owner

mattn commented Apr 20, 2022

Thank you!

@mattn mattn mentioned this pull request Apr 20, 2022
Closed
@delfick
Copy link

delfick commented Apr 21, 2022

Thanks!!!

@fsouza
Copy link
Contributor Author

fsouza commented Apr 21, 2022

Oh I just realized that I have a bad copy and pasta test. I'll send a follow-up PR with a better test.

@fsouza fsouza deleted the rootMarker-improvements branch April 21, 2022 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to skip linting/formatting if rootMarkers can't be resolved?
3 participants
@fsouza @mattn @delfick