Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to check a io.Reader instead of raw file descriptor #85

Open
cardil opened this issue Mar 15, 2023 · 1 comment
Open

Allow to check a io.Reader instead of raw file descriptor #85

cardil opened this issue Mar 15, 2023 · 1 comment

Comments

@cardil
Copy link

cardil commented Mar 15, 2023 •
edited
Loading

The lib allows checking TTY versus a raw file descriptor. It would be convenient to allow checking of a given io.Reader instead, as pointed out by @dolmen in #80 (comment)
@dolmen
Copy link
Contributor

dolmen commented Mar 23, 2023 •
edited
Loading

I'm now fully against this feature as I explained here: #80 (comment)

This is just a convenience API and it is still possible to make this feature available in another package using go-isatty as backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dolmen @cardil