rad.js and rad.min.js out of sync

[aleemb]

Strangely enough, bug #3 was only fixed in rad.min.js but not rad.js or maybe I am missing something?

[mattnish]

Sorry about the inconsistency @aleemb

Were you using the rad.js on the demo or github? The demo's rad.js might be outdated, since I may have only updated the minified version.

Thanks.

[mattnish]

If it's the demo's rad.js, I'll update it.

[mattnish]

@aleemb I just tested Rad.js and it seems to work just fine. I've re-copied the JS over to the demo again just to be sure it has the most updated version, but it should all be good.

https://primary-colored.5apps.com/

[aleemb]

I was referring to the GitHub repo. In rad.js on line 62 you have:

var pWidth = this.adParent.width();
if(this.options.maxWidth){

In the rad.min.js you have:

var pWidth=this.adParent.width();
pWidth -= parseInt(this.adParent.parent().css("marginLeft").replace("px",""))+parseInt(this.adParent.parent().css("marginRight").replace("px",""));

That bit with the pWidget -= parseInt... is missing from rad.js

I realized this when I tried to minify rad.js myself as part of my css build process.

[mattnish]

Whoa, you're totally right. Sorry I missed that. I thought I updated it before.

Thanks for catching that bug. Great job.