warnings when building with -Weverything

[core-code]

all of these individual warnings come up when compiling ONOXMLDocument.m with -Weverything

-Wshadow
-Wsign-conversion
-Wfloat-conversion
-Wconversion
-Wnullable-to-nonnull-conversion
-Wcast-qual

[mattt]

Thanks for bringing this to my attention, @core-code. I just pushed version 2.1.0, which should resolve all of the warnings you were seeing. Please let me know if there are any stray ones that I missed, and I'll be happy to take another look.

[core-code]

awesome thanks.

just a minor heads-up, i think the #pragma clang diagnostic push at the bottom of ONOXMLDocument.h should read "pop" not "push"

[mattt]

😓 Yikes. That's no good. I'm surprised the compiler didn't warn about that.

I fixed this with 39ece84, and fixed a related issue I found in Xcode 9.4.1 with 33b38b8. These are pushed with 2.1.1.