Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koans won't run if there's a dot in the file path #47

Closed
sckling opened this issue Mar 4, 2015 · 8 comments
Closed

Koans won't run if there's a dot in the file path #47

sckling opened this issue Mar 4, 2015 · 8 comments

Comments

@sckling
Copy link

sckling commented Mar 4, 2015

From a mac, I'm trying to run the koans from my /Users/firstname.lastname/Project/java-koans/koans directory. Because of the dot in the file path (firstname.lastname) I get the following error:

Exception in thread "main" java.lang.RuntimeException: java.lang.RuntimeException: java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key .lastname/Project/java-koans/koans/src/beginner/aboutkoans.java
    at com.sandwich.koan.runner.RunKoans.constructSuite(Unknown Source)
    at com.sandwich.koan.runner.RunKoans.safelyConstructSuite(Unknown Source)
    at com.sandwich.koan.runner.RunKoans.runKoans(Unknown Source)
    at com.sandwich.koan.runner.RunKoans.run(Unknown Source)
    at com.sandwich.koan.constant.ArgumentType.run(Unknown Source)
    at com.sandwich.koan.cmdline.CommandLineArgument.run(Unknown Source)
    at com.sandwich.koan.cmdline.CommandLineArgumentRunner.run(Unknown Source)
    at com.sandwich.koan.runner.AppLauncher.main(Unknown Source)
Caused by: java.lang.RuntimeException: java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key .lastname/Project/java-koans/koans/src/beginner/aboutkoans.java
    at com.sandwich.util.io.classloader.DynamicClassLoader.loadClass(Unknown Source)
    ... 8 more
Caused by: java.util.MissingResourceException: Can't find resource for bundle java.util.PropertyResourceBundle, key .lastname/Project/java-koans/koans/src/beginner/aboutkoans.java
    at java.util.ResourceBundle.getObject(ResourceBundle.java:450)
    at java.util.ResourceBundle.getString(ResourceBundle.java:407)
    at com.sandwich.util.io.filecompiler.CompilerConfig.getCompilationCommand(Unknown Source)
    at com.sandwich.util.io.filecompiler.FileCompilerAction.onFile(Unknown Source)
    at com.sandwich.util.io.FileOperation.operate(Unknown Source)
    at com.sandwich.util.io.filecompiler.FileCompiler.compile(Unknown Source)
    at com.sandwich.util.io.classloader.DynamicClassLoader.compile(Unknown Source)
    ... 9 more
@matyb
Copy link
Owner

matyb commented Mar 4, 2015

Oh boy, no shortage of surprises from variations in filesystem's :) I'll check this out tonight

@DavidWhitlock
Copy link
Contributor

Hey, @matyb. I fixed this in my fork last summer: JoyOfCodingPDX@4a8c469 (JoyOfCodingPDX#8)

Let me know if you'd like me to submit a pull request.

@matyb
Copy link
Owner

matyb commented Mar 5, 2015

Ah yeah I see what you did... Looks like one of those mistakes I make when I'm short on sleep :)

@matyb
Copy link
Owner

matyb commented Mar 5, 2015

A PR would be cool so you can be attributed with the fix

@DavidWhitlock
Copy link
Contributor

Will do.

On Wed, Mar 4, 2015 at 7:28 PM, Mat Bentley notifications@github.com
wrote:

A PR would be cool so you can be attributed with the fix


Reply to this email directly or view it on GitHub
#47 (comment).

David Whitlock
Adjunct Lecturer
Portland State University

DavidWhitlock added a commit to JoyOfCodingPDX/java-koans that referenced this issue Mar 5, 2015
@matyb
Copy link
Owner

matyb commented Mar 5, 2015

Thanks for the fix David. I've got it built and it tests cleanly.

sckling - chime in if this didn't fix it for you.

@matyb matyb closed this as completed Mar 5, 2015
@sckling
Copy link
Author

sckling commented Mar 5, 2015

It works now! Thanks guys for the quick fix!

On Wed, Mar 4, 2015 at 9:53 PM, Mat Bentley notifications@github.com
wrote:

Thanks for the fix David. I've got it built and it tests cleanly.

sckling - chime in if this didn't fix it for you.


Reply to this email directly or view it on GitHub
#47 (comment).

@DavidWhitlock
Copy link
Contributor

Excellent. Glad I could help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants