New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge event approvals are in double-past tense #25

Closed

totte opened this issue Oct 28, 2019 · 0 comments · Fixed by #23

totte commented Oct 28, 2019

Somewhere here things go awry: https://github.com/maubot/gitlab/blob/master/gitlab-webhook.go#L216

When I approve a merge request, the GitLab bot sends a notice like so:

[totte/foo] totte approveded merge request Initial commit (!1)

It should be as follows:

[totte/foo] totte approved merge request Initial commit (!1)

L0ric0 mentioned this issue

WIP: move to the maubot plugin framework #23

Merged

35 tasks

tulir closed this as completed in #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment