Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML editor reorders HTML xmlns attributes and replaces part of an HTML xmlns attribute with emoji #2440

Closed
snowcoda opened this issue Sep 1, 2016 · 1 comment
Closed

HTML editor reorders HTML xmlns attributes and replaces part of an HTML xmlns attribute with emoji #2440

snowcoda opened this issue Sep 1, 2016 · 1 comment
Assignees
@alanhartless
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Milestone
2.2.1

Comments

@snowcoda
Copy link

snowcoda commented Sep 1, 2016 •
edited by dbhurley
Loading

What type of report is this:

Q A
Bug report? Yes
Feature request? No
Enhancement? No

Description:

When using an HTML template with xmlns attributes on the HTML specific to resolving some issues in Outlook email rendering, part of the attribute gets changes to what I assume is an emoji.

If a bug:

Q A
Mautic version 2.1.1
PHP version 7

Steps to reproduce:

  1. Create a new email campaign
  2. Name te campagin and set a segment
  3. Go to the content tab
  4. Click the source code button
  5. Add the following to the markup:
    <html xmlns="http://www.w3.org/1999/xhtml" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office">
  6. Save the email
  7. Open the email
  8. Click the source code button
  9. The markup will have changed to:
    <html xmlns="http://www.w3.org/1999/xhtml" xmlns:o="urn:schemas-microsoft-com??office" xmlns:v="urn:schemas-microsoft-com:vml">

NOTE: In the above, the order of the xmlns attributes has changed (probably not a big deal, but a change none the less). More critically however, one of the attributes has had part of its value replaced with an emoji symbol for 'office'.

I'm assuming the above is caused by the latest version of the Froala editor that is incorporated into Mautic.

Log errors:

Please check for related errors in the latest log file in [mautic root]/app/log/ and/or the web server's logs and post them here. Be sure to remove sensitive information if applicable.
@escopecz escopecz added the bug Issues or PR's relating to bugs label Sep 1, 2016
@alanhartless alanhartless mentioned this issue Oct 10, 2016
Merged
@alanhartless alanhartless added this to the 2.2.1 milestone Oct 10, 2016
@alanhartless alanhartless added the ready-to-test PR's that are ready to test label Oct 10, 2016
@MohHeader
Copy link

I am not sure why, but we are having this issue once again, our Mautic version is 4.4.4
the : office : is converted to 🏢
<v:roundrect xmlns:v="urn:schemas-microsoft-com:vml" xmlns:w="urn:schemas-microsoft-com🏢word">

MohHeader added a commit to MohHeader/mautic that referenced this issue Dec 31, 2022
@MohHeader
Add an extra Emoji exception for Outlook rendering
f7c5dcf 
Building on
PR: mautic#2706 (comment)
issue: mautic#2440

Just added an extra case for exceptions : office : word
@MohHeader MohHeader mentioned this issue Dec 31, 2022
Merged
RCheesley added a commit that referenced this issue May 31, 2023
@MohHeader @mabumusa1 @RCheesley
Add an extra Emoji exception for Outlook rendering (#11838)
af7eacb 
* Add an extra Emoji exception for Outlook rendering

Building on
PR: #2706 (comment)
issue: #2440

Just added an extra case for exceptions : office : word

* add space to fix for CS Fixer

---------

Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
mautibot pushed a commit to mautic/core-lib that referenced this issue May 31, 2023
@MohHeader @mabumusa1 @RCheesley
Add an extra Emoji exception for Outlook rendering (#11838)
3382f77 
* Add an extra Emoji exception for Outlook rendering

Building on
PR: mautic/mautic#2706 (comment)
issue: mautic/mautic#2440

Just added an extra case for exceptions : office : word

* add space to fix for CS Fixer

---------

Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alanhartless alanhartless

Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
4 participants
@alanhartless @escopecz @MohHeader @snowcoda