Prevent 🏢 in Outlook email <html> tag from getting converted to emoji #2706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanhartless
added
bug
|
Yes, the |
escopecz
added
the
pending-test-confirmation
virlatinus
approved these changes
Oct 12, 2016
MohHeader
added a commit
to MohHeader/mautic
that referenced
this pull request
Dec 31, 2022
Building on PR: mautic#2706 (comment) issue: mautic#2440 Just added an extra case for exceptions : office : word
RCheesley
added a commit
that referenced
this pull request
May 31, 2023
* Add an extra Emoji exception for Outlook rendering Building on PR: #2706 (comment) issue: #2440 Just added an extra case for exceptions : office : word * add space to fix for CS Fixer --------- Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com> Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
mautibot
pushed a commit
to mautic/core-lib
that referenced
this pull request
May 31, 2023
* Add an extra Emoji exception for Outlook rendering Building on PR: mautic/mautic#2706 (comment) issue: mautic/mautic#2440 Just added an extra case for exceptions : office : word * add space to fix for CS Fixer --------- Co-authored-by: Mohammad Abu Musa <m.abumusa@gmail.com> Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Because
:officewas in an Outlook's email html tag, it was converted to the emoji equivalent of the short tag. This PR adds support to define exceptions which basically just reverts such cases that were converted to emoji's to begin with.Steps to test this PR:
<html xmlns="http://www.w3.org/1999/xhtml" xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office">:office:should remain intact.Steps to reproduce the bug:
:officeshould have been converted to an office emoji