Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an extra Emoji exception for Outlook rendering #11838

Merged
merged 5 commits into from
May 31, 2023
Merged

Add an extra Emoji exception for Outlook rendering #11838

merged 5 commits into from
May 31, 2023

Conversation

MohHeader
Copy link

Q A
Bug fix? (use the a.b branch) [ Y ]
New feature/enhancement? (use the a.x branch) [ N ]
Deprecations? [ N ]
BC breaks? (use the c.x branch) [ N ]
Automated tests included? [ N ]

Description:

Building on
PR: #2706 (comment)
issue: #2440

Just added an extra case for exceptions : office:word

@MohHeader
Add an extra Emoji exception for Outlook rendering
f7c5dcf 
Building on
PR: mautic#2706 (comment)
issue: mautic#2440

Just added an extra case for exceptions : office : word
@cla-bot
Copy link

cla-bot bot commented Dec 31, 2022

Thank you for your contribution! We require all contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact the Product Team on Slack (get an invite at https://mautic.org/slack). CLA has not been signed by @MohHeader.

jos0405
jos0405 previously approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@jos0405 jos0405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works in various outlook versions

image

image

image

@jos0405
Copy link
Contributor

jos0405 commented Jan 6, 2023

@MohHeader. thank you for your contribution, really appreciate it. Could you sign the cla as written above so we can merge this?

@jos0405 jos0405 added bug Issues or PR's relating to bugs pending-test-confirmation PR's that require one test before they can be merged labels Jan 6, 2023
@mabumusa1 mabumusa1 self-requested a review January 6, 2023 11:43
mabumusa1
mabumusa1 previously approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, this PR is good to go.

Thanks @MohHeader please sign the contributor agreement so we can merge this PR

@jos0405 jos0405 added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged pending-feedback PR's and issues that are awaiting feedback from the author and removed pending-test-confirmation PR's that require one test before they can be merged labels Jan 6, 2023
@mabumusa1 mabumusa1 removed the ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged label Jan 11, 2023
@mabumusa1
Copy link
Member

@MohHeader following up with you on the agreement signing. looking forward to having you as part of the community

@MohHeader
Copy link
Author

@MohHeader following up with you on the agreement signing. looking forward to having you as part of the community

Thanks, it's my honor
I have signed it already, please let me know if I need to re-sign it again.

@mabumusa1
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The PR contributors have signed the contributors agreement label Jan 12, 2023
@cla-bot
Copy link

cla-bot bot commented Jan 12, 2023

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@mabumusa1
Copy link
Member

@MohHeader thanks for your contribution, please fix the pending issues then it will be ready to be merged

@MohHeader
Copy link
Author

@MohHeader thanks for your contribution, please fix the pending issues then it will be ready to be merged

@mabumusa1 I am really sorry, but I am not sure what should I do,
Can I delete my PR, and someone of the team makes the required update? to fix the original issue

I am not a PHP developer, nor I know what is "CS Fixer" that is failing

Thanks for your understanding

@MohHeader MohHeader dismissed stale reviews from mabumusa1 and jos0405 via 72bf45f May 14, 2023 18:12
@MohHeader
Copy link
Author

@mabumusa1 I am really sorry, after 5 Months just to find all I needed to do was to add " " extra spaces, I believe the PR is now ready

mabumusa1
mabumusa1 approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@mabumusa1 mabumusa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and ready to merge

@mabumusa1
Copy link
Member

@mabumusa1 I am really sorry, after 5 Months just to find all I needed to do was to add " " extra spaces, I believe the PR is now ready

Thanks @MohHeader I just reviewed and it will be merged soon

@mabumusa1 mabumusa1 added ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged and removed pending-feedback PR's and issues that are awaiting feedback from the author labels May 21, 2023
@mabumusa1 mabumusa1 added this to the 4.4.9 milestone May 21, 2023
@RCheesley RCheesley merged commit af7eacb into mautic:4.4 May 31, 2023
18 checks passed
@RCheesley
Copy link
Sponsor Member

@all-contributors please add @MohHeader for code

@allcontributors allcontributors bot mentioned this pull request May 31, 2023
Merged
@allcontributors
Copy link
Contributor

@RCheesley

I've put up a pull request to add @MohHeader! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mabumusa1 mabumusa1 mabumusa1 approved these changes

@jos0405 jos0405 jos0405 left review comments

Assignees

@MohHeader MohHeader

Labels
bug Issues or PR's relating to bugs cla-signed The PR contributors have signed the contributors agreement ready-to-commit PR's with 2 successful tests, 1 approval, automated tests and docs and is ready to be merged
Projects
Open Source Fridays
Archived in project
Milestone
4.4.9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MohHeader @jos0405 @mabumusa1 @RCheesley