Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #6946 (Fix segment filters without object) #7168

Merged
merged 2 commits into from Jan 29, 2019
Merged

Revert #6946 (Fix segment filters without object) #7168

merged 2 commits into from Jan 29, 2019

Conversation

kuzmany
Copy link
Member

@kuzmany kuzmany commented Jan 24, 2019 •
edited

Please be sure you are submitting this against the staging branch.

Q A
Bug fix?
New feature?
Automated tests included?
Related user documentation PR URL
Related developer documentation PR URL
Issues addressed (#s or URLs)
BC breaks?
Deprecations?

Description:

Revert #6946
This change return noticed error with add/edit email.

Steps to reproduce the bug:

  1. Load any PR on mautibox with actual staging https://mautibox.com/7162
  2. Try edit email
  3. See error

Steps to test this PR:

  1. Load up this PR
  2. Try edit email
    3: Everything should works properly

@kuzmany kuzmany added bug Issues or PR's relating to bugs WIP PR's that are not ready for review and are currently in progress labels Jan 24, 2019
@kuzmany kuzmany added this to the 2.15.1 milestone Jan 24, 2019
@kuzmany kuzmany added ready-to-test PR's that are ready to test and removed WIP PR's that are not ready for review and are currently in progress labels Jan 24, 2019
@kuzmany kuzmany mentioned this pull request Jan 29, 2019
Merged
@alanhartless alanhartless added this to Ready to Test (first time) in Mautic 2 via automation Jan 29, 2019
@alanhartless alanhartless merged commit 79b45a8 into mautic:staging Jan 29, 2019
Mautic 2 automation moved this from Ready to Test (first time) to Merged Jan 29, 2019
@kuzmany kuzmany deleted the revert-fix-segments-filter-without-object branch January 29, 2019 18:23
@alanhartless alanhartless added this to Merged in 2.15.1 Jan 31, 2019
@kuzmany kuzmany mentioned this pull request Feb 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanhartless alanhartless alanhartless approved these changes

Assignees
No one assigned
Labels
bug Issues or PR's relating to bugs ready-to-test PR's that are ready to test
Projects
No open projects
2.15.1
Merged
Milestone
2.15.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kuzmany @alanhartless