Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize "data" resources. #2

Merged
merged 1 commit into from
Oct 7, 2016

Conversation

josh-padnick
Copy link
Contributor

Previously, the terraform plugin for vscode only recognized resources starting with the keyword resource. But in Terraform 0.7.x, a new resource type data was introduced. This is a naive implementation to support that.

Note that while I'm using this locally, I have not tested this thoroughly, so this PR is more of an invitation to complete this work. There may be unique syntax for the data resources that this admittedly simple change doesn't account for.

Previously, the terraform plugin for vscode only recognized resources starting with the keyword `resource`. But in Terraform 0.7.x, a new resource type `data` was introduced. This is a naive implementation to support that.
@boyvinall
Copy link

I just made exactly the same change to mine! Thanks for doing the PR @josh-padnick.

@mauve - would be great to get this merged please, thanks.

@mauve mauve merged commit c1b16e7 into hashicorp:master Oct 7, 2016
@mauve
Copy link
Contributor

mauve commented Oct 7, 2016

thanks, I merged and published 0.0.3 to the marketplace

@ghost ghost locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants