[WIP/draft] Bring Python wrapper using pybind11 back #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into threading issues with callbacks, and presumably into GIL locking issues as well. Therefore, for now, let's just use sync interfaces.
We should use the user callback functionality.
This is a first proof of concept. This now needs to added to the build.
Why crazy - or crazy "just for Python" (or just crazy because you know @JonasVautherin :-) )? I'm biased, but from what I can see the end result of the gRPC/Rx pipeline should be very consistent - which is a happy thing for a tech writer. |
I do this because it makes it is more readable, is consistent with other enums, structs used in a plugin class, and also because it is inconsistent with other plugins and therfore made the pybind stuff hard.
This solves the pip install problem.
All this stuff is just moved to the DronecodeSDK-Python repository.
They are moved to DronecodeSDK-Python/examples.
julianoes
changed the title
|
This is now replaced with https://github.com/Dronecode/DronecodeSDK-Python |
|
@JonasVautherin we might want to cherry-pick 164801a |
|
Yep that would be fine for me! |
|
Done in #595. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another try with pybind11 and based on the work from #37.