Fix MAVLink Passthrough unsubscription #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of always unregistering all handlers for a cookie, we would like to be able to unregister single handlers.
The API docs say that nullptr can be used to unregister. Therefore, we should not add nullptr to the mavlink handlers but unregister properly.
This resolves the case where an API user tries to unregister while still in the callback. In that case the callback gets erased from the mavlink_handler_table and this causes the caller's scope to be destroyed. We can prevent this by copying callback and the message argument and add it to the user callback queue. Presumably, this can have performance implications but I think we want to make sure not to crash first.
JonasVautherin
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #740. For more details check commits messages.