Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend support for offboard/set_attitude #743

Merged
merged 4 commits into from
May 13, 2019
Merged

backend support for offboard/set_attitude #743

merged 4 commits into from
May 13, 2019

Conversation

a6a3uh
Copy link
Contributor

@a6a3uh a6a3uh commented May 9, 2019

set_attitude method was added recently to offboard plugin and it is not supported in resent offboard grpc backend introduced with great pull request So this adds set_attitude support.

@a6a3uh a6a3uh mentioned this pull request May 9, 2019
Merged
@a6a3uh
Copy link
Contributor Author

a6a3uh commented May 9, 2019

The corresponding Droncode-Proto PR is here

@a6a3uh a6a3uh mentioned this pull request May 9, 2019
Closed
@a6a3uh
Copy link
Contributor Author

a6a3uh commented May 9, 2019

Corresponding DronecodSDK-Python PR

JonasVautherin
JonasVautherin requested changes May 9, 2019
View reviewed changes
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a fix for a small typo.

Also, I merge your PR in DronecodeSDK-Proto, so you may now update the submodule accordingly.

Thanks a lot for the work! :-)

backend/test/offboard_service_impl_test.cpp Outdated Show resolved Hide resolved
@JonasVautherin
Copy link
Collaborator

Oh, and you should fix the indentation with $ make fix_style, too.

a6a3uh and others added 3 commits May 10, 2019 20:11
@a6a3uh @JonasVautherin
Update backend/test/offboard_service_impl_test.cpp
7db3ebd 
typo fix

Co-Authored-By: Jonas Vautherin <jonas.vautherin@gmail.com>
@a6a3uh
fix style
7190e21
@a6a3uh
updated proto
1f9043e
julianoes
julianoes approved these changes May 13, 2019
View reviewed changes
Copy link
Collaborator

@julianoes julianoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @a6a3uh!

@julianoes julianoes merged commit 4f67c48 into mavlink:develop May 13, 2019
@a6a3uh a6a3uh deleted the add-attitude-to-backend branch May 13, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasVautherin JonasVautherin JonasVautherin requested changes

@julianoes julianoes julianoes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@a6a3uh @JonasVautherin @julianoes