Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration_tests: add attitude rate flips #753

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

julianoes
Copy link
Collaborator

I wanted to improve the attitude and altitude control but realized that altitude control was not working well with just the P controller.

Therefore, instead of implementing attitude control using attitude rate using offboard mode it probably makes more sense to implement flips which is what's likely used for rate control.

For attitude or altitude control it's generally easier to actually use the attitude control or altitude (velocity) control API directly.

JonasVautherin
JonasVautherin previously approved these changes May 29, 2019
Copy link
Collaborator

@JonasVautherin JonasVautherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JonasVautherin
Copy link
Collaborator

(Are you trying to get that in before #724? 😆)

@julianoes
Copy link
Collaborator Author

Hah, don't care, I can rebase too.

Instead of implementing attitude control using attitude rate using
offboard mode it probably makes more sense to implement flips.

For attitude control it's generally easier to actually use the attitude
control which already exists in PX4.
@julianoes julianoes force-pushed the improve-offboard-rate-control branch from 3c9304d to b221676 Compare May 30, 2019 07:13
@julianoes julianoes merged commit 2068c48 into develop Jun 11, 2019
@julianoes julianoes deleted the improve-offboard-rate-control branch June 11, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants