integration_tests: add attitude rate flips #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Are you trying to get that in before #724? 😆) |
|
Hah, don't care, I can rebase too. |
Instead of implementing attitude control using attitude rate using offboard mode it probably makes more sense to implement flips. For attitude control it's generally easier to actually use the attitude control which already exists in PX4.
julianoes
force-pushed
the
improve-offboard-rate-control
branch
from
3c9304d
to
b221676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to improve the attitude and altitude control but realized that altitude control was not working well with just the P controller.
Therefore, instead of implementing attitude control using attitude rate using offboard mode it probably makes more sense to implement flips which is what's likely used for rate control.
For attitude or altitude control it's generally easier to actually use the attitude control or altitude (velocity) control API directly.