Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version generated files #839

Merged
merged 4 commits into from Aug 13, 2019
Merged

Version generated files #839

merged 4 commits into from Aug 13, 2019

Conversation

JonasVautherin
Copy link
Collaborator

@thomasetter: FYI

  • Generate protobuf and gRPC source files from a script (instead of doing it in the cmake configure step)
  • Version those generated files

Resolves #816.

@JonasVautherin
Copy link
Collaborator Author

hmm not passing the style checks. @julianoes: do you know if there is a way to ignore a directory in fix_style.sh? I see some style_ignore logic but I'm not sure I completely get it 😕.

This was referenced Aug 12, 2019
@julianoes
Copy link
Collaborator

@JonasVautherin it looks like the style-ignore.txt file was removed at some point. I've added it back and it seems to work.

@JonasVautherin
Copy link
Collaborator Author

Ubuntu 14.04 with gcc6 is failing for an obscure reason 😅.

@julianoes
Copy link
Collaborator

Yer I've seen this in other places. It's the coveralls thing, maybe because coveralls was down or being maintained: https://status.coveralls.io/.

@julianoes julianoes merged commit f3d5b59 into develop Aug 13, 2019
@julianoes julianoes deleted the 816-version-generated-files branch August 13, 2019 11:43
@JonasVautherin JonasVautherin changed the title 816 version generated files Version generated files Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move protoc generation out of cmake and version generated files
2 participants