Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that PARAM_SET is a permanent write #1018

Merged
merged 1 commit into from Nov 16, 2018

Conversation

hamishwillee
Copy link
Collaborator

The previous definition indicates that the write was temporary and that the setting would not survive reboot. It also indicated that you could send MAV_ACTION_STORAGE_WRITE to write the value to permanent storage, but this value does not appear to exist.

On PX4, PARAM_SET writes the value to RAM and then immediately to permanent storage (a cached write).

This update is to reflect the actual behaviour.

@hamishwillee
Copy link
Collaborator Author

@auturgy This is true for ArduPilot too right? I think the definition just way out of date.

@auturgy
Copy link
Collaborator

auturgy commented Nov 5, 2018

True for ArduPilot. Might be worth seeing if you can check with SmartAP, SLUGS, and whatever other consumers of mavlink are out there (cameras?)

@LorenzMeier LorenzMeier merged commit 89267df into master Nov 16, 2018
@LorenzMeier LorenzMeier deleted the hamishwillee-param_set branch November 16, 2018 08:53
@hamishwillee
Copy link
Collaborator Author

True for ArduPilot. Might be worth seeing if you can check with SmartAP, SLUGS, and whatever other consumers of mavlink are out there (cameras?)

FYI @auturgy I did send out some emails on this but got no response yet. Alternative was to make ambiguous about whether params are permanently stored or make it clear that this is for temporary writes and make PX4 and ArduPilot implementations non-compliant. Both of those seem less useful.

It does mean that if there is a valid use case for temporary writes, we will need to invent something new.
That would be a good candidate for an extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants