Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update according to the final ASTM Remote ID standard and remove WIP #1317

Merged
merged 3 commits into from
Mar 16, 2020

Conversation

friissoren
Copy link
Contributor

I did the final smaller edits needed to align the message definitions with the final ASTM Remote ID standard.

I have uploaded some documentation here:
mavlink/mavlink-devguide#220

Once that PR is approved and merged, I assume we should be able to remove the Work in Progress marks as well?

<entry value="2" name="MAV_ODID_UA_TYPE_ROTORCRAFT">
<description>Rotorcraft (including Multirotor).</description>
<entry value="2" name="MAV_ODID_UA_TYPE_HELICOPTER_OR_MULTIROTOR">
<description>helicopter or Multirotor.</description>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helicopter or multirotor.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 10, 2020

Generally we remove the WIP when we're sure we have a workable API, and that is the point there is an implementation. Is there a PX4, ArduPilot or other flight stack implementation - and if not, is one planned?

@auturgy @LorenzMeier @julianoes Any comments on this final revision of the messages - ie expectation is that the ASTM remote ID messages will not be "stable".

@magicrub
Copy link
Contributor

I could probably whip up an ArduPilot implantation.

@hamishwillee
Copy link
Collaborator

@magicrub That would be great (though I don't know if there is a "real" module to play with). Just looking at the docs we might be missing a component ID.

@auturgy
Copy link
Collaborator

auturgy commented Mar 10, 2020

@apache405 might have hardware.
Re stability: It’s unlikely to change in the short term. Takes a long time to get through F38, so I think remove WIP.

Some of the UA Type names were changed in the final
version of the ASTM Remote ID standard.

Signed-off-by: Soren Friis <soren.friis@intel.com>
@friissoren
Copy link
Contributor Author

Review comment fixed.

About implementations, I don't know if anyone else than me/Intel have used these new Mavlink messages. I have used them for sending data from a flight controller to a Bluetooth transmitter module in a so-far unpublished Intel drone.

friissoren and others added 2 commits March 12, 2020 10:23
@hamishwillee hamishwillee merged commit 0ea5f80 into mavlink:master Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants