Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAV_PROTOCOL_CAPABILITY_FLIGHT_TERMINATION - improve linking to command #1774

Merged
merged 4 commits into from
Feb 22, 2022

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jan 6, 2022

MAV_PROTOCOL_CAPABILITY_FLIGHT_TERMINATION this explicitly names the supported command. That both removes any ambiguity about the command (were there to be one in future) and also creates a link in the documentation.

Note that we probably shouldn't have wasted a protocol bit on this. It isn't needed - you could just sent the command with param1=0 and the vehicle should not terminate, but should ACK to indicate that it understand the command.

@hamishwillee
Copy link
Collaborator Author

We should define what flight termination means:

On PX4 the FC sets failsafe values, which for FW attempt a glide land, and for MC just turn off all motors. You can also trigger things like a chute off unused ports. On ArduPlane Plane it looks like this does similar, but not clear what Copter does

I think the common story here is that the vehicle will immediately land and that this operation cannot be reset until the vehicle has landed? Anything much else that can be said? I'd like to mention turning off motors if both platforms do that.

@auturgy @julianoes Otherwise OK?

@julianoes
Copy link
Collaborator

I think the common story here is that the vehicle will immediately land

I would not call it land although it will eventually "land" on the ground. :trollface: In my mind termination is something like parachute, fixed bank angle, or drop like a stone. Otherwise you could just tell it to "land" which would be more graceful.

@hamishwillee
Copy link
Collaborator Author

Agreed by @auturgy too (offline). Merging.

@julianoes I think I assigned you a bug in PX4 to match to this behaviour (last week).

@hamishwillee hamishwillee merged commit fd7ccfb into master Feb 22, 2022
@hamishwillee hamishwillee deleted the cap_flightterm branch February 22, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants