MAV_WINCH_STATUS_CLUTCH_ENGAGED: clarify definition #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rmackay9 Can I merge this please? |
|
@rmackay9 Ping. |
|
This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNLESS AGREED WITH @rmackay9
MAV_WINCH_STATUS_CLUTCH_ENGAGEDtext was "Winch clutch is engaged allowing motor to move freely". Those things are mutually exclusive - an engaged clutch is driving the motor.As discussed in #1766 (comment) we can't change the meaning because it is being used currently. But we can clarify what it really means and that we understand it is misnamed.
@rmackay9 Does this work for you if I merge it now. The idea is that there is now no longer any pressure on you to change
MAV_WINCH_STATUS_CLUTCH_ENGAGEDin any kind of timely manner, or really at all if it is not possible to do safely.