-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jump commands - can only be used in missions #1871
base: master
Are you sure you want to change the base?
Conversation
hamishwillee
commented
Aug 4, 2022
- This specifies the minimum repeat count on a jump tag as 1, rather than 0. If a number < 1 is set the mission item is invalid and should be ignored (skipped). Note "ignored" - this is not a basis for rejecting the mission - should it be?
- I also set the min value for the sequence to 1 - ie the first item in the mission. What this means is that you can't set this to 0 or the "home" position.
- I think this makes sense.
- We could also specify what happens if <1 was entered - should we. I would suggest that perhaps the system ignore this and just use 1
- I have stated these are not intended for use as commands. The semantics are otherwise a bit confusing - i.e. if I send this as a command, am I trying to reset the mission internal counters? etc.
@julianoes @auturgy As discussed in dev call. Made it a draft as there are "questions to be asked". |
12de498
to
3326fae
Compare
3326fae
to
4e679db
Compare
Jump to the desired command in the mission list. | ||
Repeat this action only the specified number of times. | ||
This is intended for missions, and must not be used as a command outside of missions. | ||
</description> | ||
<param index="1" label="Number" minValue="0" increment="1">Sequence number</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note, reverted the change to minimum values.
The only actual content change is the last line:
This is intended for missions, and must not be used as a command outside of missions.
Originally I was concerned about the minimum values too. But thats unnecessarily proscriptive. Where not using this outside of missions should just be common sense.