Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump commands - can only be used in missions #1871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hamishwillee
Copy link
Collaborator

  1. This specifies the minimum repeat count on a jump tag as 1, rather than 0. If a number < 1 is set the mission item is invalid and should be ignored (skipped). Note "ignored" - this is not a basis for rejecting the mission - should it be?
  2. I also set the min value for the sequence to 1 - ie the first item in the mission. What this means is that you can't set this to 0 or the "home" position.
    • I think this makes sense.
    • We could also specify what happens if <1 was entered - should we. I would suggest that perhaps the system ignore this and just use 1
  3. I have stated these are not intended for use as commands. The semantics are otherwise a bit confusing - i.e. if I send this as a command, am I trying to reset the mission internal counters? etc.

@hamishwillee hamishwillee marked this pull request as draft August 4, 2022 01:20
@hamishwillee
Copy link
Collaborator Author

@julianoes @auturgy As discussed in dev call. Made it a draft as there are "questions to be asked".

Jump to the desired command in the mission list.
Repeat this action only the specified number of times.
This is intended for missions, and must not be used as a command outside of missions.
</description>
<param index="1" label="Number" minValue="0" increment="1">Sequence number</param>
Copy link
Collaborator Author

@hamishwillee hamishwillee Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, reverted the change to minimum values.

The only actual content change is the last line:

This is intended for missions, and must not be used as a command outside of missions.

Originally I was concerned about the minimum values too. But thats unnecessarily proscriptive. Where not using this outside of missions should just be common sense.

@hamishwillee hamishwillee marked this pull request as ready for review September 14, 2022 05:23
@hamishwillee hamishwillee changed the title Jump commands - specify minimum repeats as 1 Jump commands - can only be used in missions Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants