minimal: try to make component ID less confusing #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my attempt to avoid some confusion around MAV_COMP_ID_SYSTEM_CONTROL. Essentially, it shouldn't be used anymore. Replacing it with MAV_COMP_ID_ALL only makes sense as a target though, and not as a source.
julianoes
force-pushed
the
pr-system-control
branch
from
18b1995
to
d041b95
Compare
|
Works for me! Undraft and let's rubber stamp in the dev call. |
|
Merging, as discussed in the dev call. FYI @julianoes I modified this a little to move the specific deprecation information inside that tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to avoid some confusion around MAV_COMP_ID_SYSTEM_CONTROL. Essentially, it shouldn't be used anymore.
Replacing it with MAV_COMP_ID_ALL only makes sense as a target though, and not as a source.
@hamishwillee let me know what you think. I had someone confused about this the other day but I can't remember the specifics. What I do remember is making a todo to make it less confusing, and this is my attempt to do so.