Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate .deb file in CI #2037

Closed
wants to merge 1 commit into from
Closed

Generate .deb file in CI #2037

wants to merge 1 commit into from

Conversation

julianoes
Copy link
Collaborator

@julianoes julianoes commented Sep 12, 2023

This is an attempt to publish a .deb file for Debian/Ubuntu containing the generated MAVLink headers.

This also adds support for pkgconfig by the cmake build/install.

The release version is taken from github tags in the form of vX.Y.Z.
We just use the git hash instead for now.

The idea would be to use this .deb file to install MAVLink as required by MAVSDK.

FYI @hamishwillee and @auturgy.

debian/copyright Outdated Show resolved Hide resolved
debian/rules Show resolved Hide resolved
@julianoes julianoes force-pushed the pr-produce-dot-debs branch 2 times, most recently from 40521fc to 1a80324 Compare March 4, 2024 21:13
This is an attempt to publish a .deb file for Debian/Ubuntu containing
the generated MAVLink headers.

This also adds support for pkgconfig by the cmake build/install.

The release version is taken from the git hash.

Signed-off-by: Julian Oes <julian@oes.ch>
@julianoes
Copy link
Collaborator Author

@JonasVautherin now I wonder where we would put this .deb file because we're not actually making releases.

@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 6, 2024

@JonasVautherin now I wonder where we would put this .deb file because we're not actually making releases.

We're backwards compatible, so we could put it in-tree as latest build and overwrite each time we generate the library. Or in its own repo, but seems annoying.

Or we bite the bullet and agree a release process. That requires agreement and time. I don't think insurmountable - we've never committed enough time to make a solid proposal.

@julianoes
Copy link
Collaborator Author

I wouldn't put binaries in source. Versioning sounds reasonable, doesn't it.

@julianoes julianoes closed this Mar 7, 2024
@hamishwillee
Copy link
Collaborator

So this is closed, does that mean I don't have to think about a response to "I wouldn't put binaries in source. Versioning sounds reasonable, doesn't it."?

@julianoes julianoes reopened this Mar 13, 2024
@julianoes
Copy link
Collaborator Author

Closed by accident, pretty sure.

@julianoes
Copy link
Collaborator Author

Oh, I forgot about the aspect of needing a github release to actually put the .deb file, and that's clearly not happening any time soon. I'm giving up on this, it needs a broader push regarding MAVLink versioning.

@julianoes julianoes closed this Mar 27, 2024
@julianoes julianoes deleted the pr-produce-dot-debs branch March 27, 2024 21:53
@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 27, 2024

Well, as discussed, we could have a meaningless release - i.e. weekly tag say. As long as it is clear this is just for the purpose of meeting deb file requirements and doesn't map to particular milestones or deliverables then why not. I'd trigger it automatically on mavlink updates of ArduPilot/Pymavlink submodule. If we were being ambitious, we could also sync those to the git hash used in Pymavlink releases.

@julianoes
Copy link
Collaborator Author

Right. I'll think more about it.

@JonasVautherin
Copy link

It could also be triggered e.g. every two weeks, and the tag would just be a date. Some kind of "bi-weekly build".

@hamishwillee
Copy link
Collaborator

I think we should do that - it's just a "tag release", not an "official release". That presumably sorts the requirement of the .deb file?

@hamishwillee
Copy link
Collaborator

FYI @JonasVautherin (@julianoes) We discussed in the dev call. MAVLink is happy for tag releases to be created in a workflow - monthly cycle preferred, but 2 week if you need it. It will just be a date release, with no tracking of changes or whatever. We're not planning on linking it to anything other than a date (such as pymavlink versions, or containing particular messages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants