Skip to content

Commit

Permalink
Merge pull request #1631 from shubham-shahh/ros2
Browse files Browse the repository at this point in the history
rectified spelling and gramatical errors
  • Loading branch information
vooon committed Oct 7, 2021
2 parents 87f2b11 + 2e5d4ed commit 5396865
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions mavros/mavros/param.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def values(self) -> 'ParamDict':
# we'll get bunch of events
self.call_pull()

# 3. if to little events come, request whole list
# 3. if too small events come, request whole list
if len(pm) < 10:
names = call_list_parameters(node=self._node,
client=self.cli_list_parameters)
Expand All @@ -241,7 +241,7 @@ class ParamDict(dict):
ParamDict wrapper.
That class holds states of parameters
and allow to upload new items.
and allows to upload new items.
"""

class NoSet:
Expand Down
2 changes: 1 addition & 1 deletion mavros/src/plugins/command.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ class CommandPlugin : public plugin::Plugin
bool & success)
{
/* Note: seems that COMMAND_INT don't produce COMMAND_ACK
* so wait don't needed.
* so wait is not needed.
*/
command_int(
broadcast,
Expand Down
8 changes: 4 additions & 4 deletions mavros/src/plugins/ftp.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ using utils::enum_value;
/**
* @brief FTP Request message abstraction class
*
* @note This class not portable, and works on little-endian machines only.
* @note This class is not portable, and works on little-endian machines only.
*/
class FTPRequest : public mavlink::common::msg::FILE_TRANSFER_PROTOCOL
{
Expand Down Expand Up @@ -173,8 +173,8 @@ class FTPRequest : public mavlink::common::msg::FILE_TRANSFER_PROTOCOL
* @brief Copy string to payload
*
* @param[in] s payload string
* @note this function allow null termination inside string
* it used to send multiple strings in one message
* @note this function allows null termination inside string
* it is used to send multiple strings in one message
*/
void set_data_string(const std::string & s)
{
Expand Down Expand Up @@ -204,7 +204,7 @@ class FTPRequest : public mavlink::common::msg::FILE_TRANSFER_PROTOCOL
#endif

// return uas->get_system_id() == target_system;
return true; // XXX TODO(vooon): probably whole method not needed anymore
return true; // XXX TODO(vooon): probably whole method is not needed anymore
}

/**
Expand Down
4 changes: 2 additions & 2 deletions mavros/src/plugins/mission_protocol_base.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ void MissionBase::handle_mission_current(
{
unique_lock lock(mutex);

// NOTE(vooon): this message do not have mission_type
// NOTE(vooon): this message does not have mission_type
// if (filter_message(mcur)) {
// return;
// }
Expand Down Expand Up @@ -377,7 +377,7 @@ void MissionBase::handle_mission_item_reached(
mavlink::common::msg::MISSION_ITEM_REACHED & mitr,
MFilter filter [[maybe_unused]])
{
// NOTE(vooon): this message do not have mission_type
// NOTE(vooon): this message does not have mission_type
// if (filter_message(mitr)) {
// return;
// }
Expand Down
4 changes: 2 additions & 2 deletions mavros/src/plugins/param.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ static constexpr const char * events = "/parameter_events";
* - real32 for float's
*
* So no reason to really use boost::any.
* But feel free to fire an issue if your AP do not like it.
* But feel free to fire an issue if your AP does not like it.
*/
class Parameter
{
Expand Down Expand Up @@ -352,7 +352,7 @@ class Parameter
}

/**
* Exclude this parameters from ~param/push
* Exclude these parameters from ~param/push
*/
static bool check_exclude_param_id(const std::string & param_id)
{
Expand Down
2 changes: 1 addition & 1 deletion mavros/src/plugins/setpoint_raw.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ class SetpointRawPlugin : public plugin::Plugin,
double thrust;

// Set Thrust scaling in px4_config.yaml, setpoint_raw block.
// ignore thrust is false by default, unless no thrust scalling is set or thrust is zero
// ignore thrust is false by default, unless no thrust scaling is set or thrust is zero
auto ignore_thrust = req->thrust != 0.0 &&
!node->get_parameter("thrust_scaling", thrust_scaling);

Expand Down
2 changes: 1 addition & 1 deletion mavros/test/test_uas.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ TEST_F(TestUAS, add_plugin__route_message__filter)
auto plugin2 = std::make_shared<MockPlugin>(uas);
auto subs2 = plugin2->rawsubs();

// XXX(vooon): silence leak warnings: they works badly with shared_ptr
// XXX(vooon): silence leak warnings: they work badly with shared_ptr
testing::Mock::AllowLeak(&(*uas));
testing::Mock::AllowLeak(&(*plugin1));
testing::Mock::AllowLeak(&(*plugin2));
Expand Down

0 comments on commit 5396865

Please sign in to comment.