plugin: ftp: Disable debugging and change level for some log messages.

Issue #128.
mavlink · Sep 22, 2014 · d9c987c · d9c987c
1 parent 4cabd34
commit d9c987c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 12 deletions.
diff --git a/mavros/src/plugins/ftp.cpp b/mavros/src/plugins/ftp.cpp
@@ -45,7 +45,7 @@
 #include <mavros/FileChecksum.h>
 
 // enable debugging messages
-#define FTP_LL_DEBUG
+//#define FTP_LL_DEBUG
 
 namespace mavplugin {
 
@@ -474,7 +474,7 @@ class FTPPlugin : public MavRosPlugin {
 		ROS_ASSERT(hdr->size == sizeof(uint32_t));
 		open_size = *req.data_u32();
 
-		ROS_DEBUG_NAMED("ftp", "FTP:Open %s: success, session %u, size %zu",
+		ROS_INFO_NAMED("ftp", "FTP:Open %s: success, session %u, size %zu",
 				open_path.c_str(), hdr->session, open_size);
 		session_file_map.insert(std::make_pair(open_path, hdr->session));
 		go_idle(false);
@@ -676,8 +676,6 @@ class FTPPlugin : public MavRosPlugin {
 		send_any_path_command(FTPRequest::kCmdCalcFileCRC32, "kCmdCalcFileCRC32: ", path, 0);
 	}
 
-	/* how to open existing file to write? */
-
 	/* -*- helpers -*- */
 
 	void add_dirent(const char *ptr, size_t slen) {

diff --git a/mavros/srv/FileChecksum.srv b/mavros/srv/FileChecksum.srv
@@ -1,4 +1,4 @@
-# FTP:Checksum
+# FTP::Checksum
 #
 # :file_path:	file to calculate checksum
 # :crc32:	file checksum

diff --git a/mavros/srv/FileOpen.srv b/mavros/srv/FileOpen.srv
@@ -1,16 +1,12 @@
 # FTP::Open
 #
-# :file_path:	used as session id in all other services
+# :file_path:	used as session id in read/write/close services
 # :size:	file size returned for MODE_READ
 # :success:	indicates success end of request
 # :r_errno:	remote errno if applicapable
 
-# 2014.09.01 Notes:
-# Current PX4 implementation don't allow anything except
-# read file or list dir.
-
 uint8 MODE_READ = 0	# open for read
-uint8 MODE_WRITE = 1	# open for write (not supported)
+uint8 MODE_WRITE = 1	# open for write
 uint8 MODE_CREATE = 2	# do creat()
 
 string file_path

diff --git a/mavros/srv/FileRename.srv b/mavros/srv/FileRename.srv
@@ -1,4 +1,4 @@
-# FTP:Rename
+# FTP::Rename
 #
 # :success:	indicates success end of request
 # :r_errno:	remote errno if applicapable