Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.8.0 #155

Closed
4 tasks done
vooon opened this issue Sep 11, 2014 · 9 comments
Closed
4 tasks done

Release 0.8.0 #155

vooon opened this issue Sep 11, 2014 · 9 comments
Milestone

Comments

@vooon
Copy link
Member

vooon commented Sep 11, 2014

I think we near release.

Issues todo:

@vooon vooon added this to the Version 0.8.0 milestone Sep 11, 2014
@mhkabir
Copy link
Member

mhkabir commented Sep 12, 2014

I haven't been getting any time at all to do any work. I will fix up the PX4 side a bit more, make it fully OK.

Can you do the mavros side? Basically it the same as on PX4 side (After I add a couple of more things)
You would have to :

  1. Remove handling of SYSTEM_TIME from GPS plugin and put it in system_status plugin.
  2. Publish UTC epoch time from message in TimeReference message for NTPD.
  3. Publish time_offset (calculated in SYSTEM_TIME callback with same logic as PX4 including reboot checks) in TimeReference message for all other mavros plugins to use.
  4. Add sending of SYSTEM_TIME message (already implemented) but also send UTC epoch time from system clock if valid ( time > 1/1/2011)
  5. Reboot checks ( I will fix this on PX4 side soon. Same logic)
  6. Use offset in a plugin (for example IMU, etc.)
  7. Send proper timestamp with message (time_boot_ms <- ROS::TimeNow in ms) in eg. VISION_ESTIMATE plugin.

We use 1/1/2011 for all validity checks.

Tell me if you are having problem in understanding anything :)

@mhkabir
Copy link
Member

mhkabir commented Sep 12, 2014

@vooon What is the status of GPS?

I see

/mavros/fix
/mavros/global_position/compass_hdg
/mavros/global_position/global
/mavros/global_position/gps_vel
/mavros/global_position/local
/mavros/global_position/rel_alt
/mavros/gps_vel

Can we make all this more compact, instead of so many topics? Can we atleast get it into a single namespace i.e global_position?

I also suggest similar structure for local position. All global data from GPS under /global_position/ and all local data under /local_position/

@vooon
Copy link
Member Author

vooon commented Sep 12, 2014

Difference is in that ~fix and ~gps_vel is RAW data from GPS module, while global_position is fused by FCU.

APM don't support global_position messages at all. Also GPS plugin is one of the oldest in system.
I think to move it to gps ns in next releases.

@mhkabir
Copy link
Member

mhkabir commented Sep 12, 2014

@vooon Does the /mavros/fix message have a valid covariance? (PX4)

@vooon
Copy link
Member Author

vooon commented Sep 12, 2014

I use nmea_navsat_driver as example, they calculate covariance from EPH value.

@vooon
Copy link
Member Author

vooon commented Sep 22, 2014

#156 moved to next release. Also i hope to update other plugins to use timesync.

@mhkabir
Copy link
Member

mhkabir commented Sep 22, 2014

I made a mistake in time sync on PX4. I thought ROS sends time since boot, but it actually sends time since epoch. I will have to rework the whole thing again...

@vooon
Copy link
Member Author

vooon commented Sep 22, 2014

Release time!

@vooon vooon closed this as completed Sep 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants